-
Notifications
You must be signed in to change notification settings - Fork 333
Add graydon to a initial-designer marker team
#1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Triage: I think the problem is that #council > Adding Graydon Hoare to an `initial-designer` marker team @ 💬
I think? |
|
I think this is largely blocked in that it has no effect, and thus probably isn't worth merging right now. It's maybe a larger questions of whether or not we want to publicly have archived teams appear on the website, or whether or not to have a consolidated alumni page, or any other kind of organization. We also don't show any marker teams, which would also be a blocker here (and generally I would prefer to avoid use of marker teams like this). I would also note that an alternate approach here would be to just add him as an alumni to another team, like core. If the intent is mainly to manage the website, then I think the council's stance has largely been that we want to delegate ownership of that to the @rust-lang/website team. If they want to figure out some way to better highlight past members and archived teams, I don't think that really needs our involvement. (There's maybe a minor concern that some people specifically don't want to be acknowledged. Probably not the case here, but something to be aware of if extending it more broadly.) |
We do actually! Since ~2 months ago or something, marker teams with a website entry are now shown on the webpage. Regarding Graydon, I would perhaps just hardcode him on the web. But having a dedicated alumni/archived team page would also be great. |
|
rust-lang/www.rust-lang.org#2202 adds archived teams to the Rust website. |
|
As the archived teams are now shown on the Rust website, this is no longer blocked. |
|
@crlf0710 Are you interested in continuing with this PR? It would be great to apply #1672 (comment). |
Yes, i rebased and applied suggested change. Hope i'm doing everything correctly! |
Dry-run check results |
|
Seems like yes, thank you! We will discuss this at the next Council meeting this Friday, and hopefully get it merged. |
|
I was asked to comment here so I will: I approve of (and am in fact a bit relieved) to appear at least somewhere in the project history! I did dedicate several years of my life to this thing, was the "tech lead" for 3 of those years, and did a lot of initial design and implementation (wrote most of rustboot, and still committer 20 on rustc after all these years). However: if you're going for completeness you should also make sure to mention a bunch of other people who predated the existence of "teams" and their associated rosters of members. I did not work alone after 2009! I have pieced together a list over the years in a private repo I'm collecting memorabilia in. I will just quote from the readme file in that repo: Early contributor listThis list is a little random, though vaguely systematic. It includes groups of (For people who migrated from one category to another over time, I've put them
|
|
amazing to see my name among legends |
This commit adds graydon hoare to a dedicated
initial-designermarker team alumni to give credit to their initial contributionscc #319