-
Notifications
You must be signed in to change notification settings - Fork 993
fix(check): Adjust format of 'rustup check' to be like Cargo #4574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Overall, I'm mixed on the results and can see this going one in several directions |
Can you elaborate? What do you like/don't like? What potential directions do you see? |
|
|
@djc I do like this style unification with |
I think I'm missing how json output mode is relevant to how things are rendered. |
@epage This is unfortunate, but currently We've changed the output of |
|
At #t-rustup > rustup/cargo output format consistency @ 💬 I had looked at how people might be using the commands programmatically and it seemed like it would be fine to change this command. Has something changed since then?
|
|
@epage I think the analysis is, from t-rustup's POV, mostly accurate, though it turned out that people are already parsing It is true that progress reporting etc. are for communication purposes. However there are still parsable elements in the output, such as:
Although arguably the number of examples might be relatively small. This is true even for Finally, the Personally though, these messages are not very good-looking, so aligning with The thing is, I do want to push that forward, but there seems to be no real way to find out the impact before the stable release happens. Beta releases are, clearly, not enough otherwise it should've worked on v1.28... Do you have any ideas in that regard? |
At least for Cargo, we don't take this level of caution. We have json messages for some parts of compilation, not even enough to recreate Cargo's output. No other end-user operations have json output at this time, whether it be publish operations, |
Discussed at #t-rustup > rustup/cargo output format consistency @ 💬