-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Add release notes for 1.92.0 #149652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add release notes for 1.92.0 #149652
Conversation
|
|
|
@rustbot ping relnotes-interest-group |
|
Hi relnotes-interest-group, this issue/PR could use some help in reviewing / cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross |
|
Hi, sorry for being late with this I wanted to ask about Release Notes for this change (#146810). We discussed this briefly on #t-compiler > Determining if a change needs release notes, but I’m still not completely sure whether they are required in my case. If they are needed, do I still have time to add them? |
|
@Kivooeo that change is already included, but you can still suggest edits here, even removing that line if you don't think it deserves mention. |
|
I meant a release blog section like here #147383 Because I still unsure about what changes require them
This line is not clear enough to me, how can I understand if change is "notable enough" |
|
Ah, the blog is much more subjective -- there's no real requirement, but it's essentially a judgement call about how many people may care about the change. @BoxyUwU is handling that in rust-lang/blog.rust-lang.org#1757. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one tiny nit
| - [`<[_]>::rotate_left`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.rotate_left) | ||
| - [`<[_]>::rotate_right`](https://doc.rust-lang.org/stable/std/primitive.slice.html#method.rotate_right) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: maybe [T]::{rotate_left,rotate_right} but meh
| Compatibility Notes | ||
| ------------------- | ||
| * [Fix backtraces with `-C panic=abort` on Linux by generating unwind tables by default](https://github.com/rust-lang/rust/pull/143613). Build with `-C force-unwind-tables=no` to keep omitting unwind tables. | ||
| - As part of the larger effort refactoring compiler built-in attributes and their diagnostics, [The future-compatibility lint `invalid_macro_export_arguments` is upgraded to deny-by-default and will be reported in dependencies too.](https://github.com/rust-lang/rust/pull/143857) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
| - As part of the larger effort refactoring compiler built-in attributes and their diagnostics, [The future-compatibility lint `invalid_macro_export_arguments` is upgraded to deny-by-default and will be reported in dependencies too.](https://github.com/rust-lang/rust/pull/143857) | |
| - As part of the larger effort refactoring compiler built-in attributes and their diagnostics, [the future-compatibility lint `invalid_macro_export_arguments` is upgraded to deny-by-default and will be reported in dependencies too.](https://github.com/rust-lang/rust/pull/143857) |
cc @rust-lang/release
r? @BoxyUwU