Skip to content

Conversation

@lolbinarycat
Copy link
Contributor

Finally tackling this again now that the search system refactor is done. The tests and the general approach were taken from the original PR.

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added the A-rustdoc-search Area: Rustdoc's search feature label Nov 29, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Testing asrawfd.js ... OK
Testing basic.js ... OK
Testing const-is-nullary-func.js ... OK
Testing core-transmute.js ... FAILED
[ query `generic:T -> generic:U`]==> '{"path":"core::mem","name":"transmute"}' was supposed to be before '{"crate":"core","name":"simd_cast","path":"core::intrinsics::simd","exactPath":"core::intrinsics::simd","ty":7,"type":{"inputs":[{"id":-1,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"output":[{"id":-2,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"where_clause":[[],[]]},"paramNames":["T","U"],"dist":2,"path_dist":0,"index":-1,"desc":"Numerically casts a vector, elementwise.","item":{"id":36082,"crate":"core","ty":7,"name":"simd_cast","normalizedName":"simdcast","modulePath":"core::intrinsics::simd","exactModulePath":"core::intrinsics::simd","entry":{"krate":10481,"ty":7,"modulePath":15288,"exactModulePath":null,"parent":null,"traitParent":null,"deprecated":false,"unstable":true,"associatedItemDisambiguator":null},"path":null,"functionData":{"functionSignature":{"inputs":[{"id":-1,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"output":[{"id":-2,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"where_clause":[[],[]]},"paramNames":["T","U"],"elemCount":2},"deprecated":false,"unstable":true,"parent":null,"traitParent":null},"displayPath":"<span>core::</span><span>intrinsics::</span><span>simd::</span>","fullPath":"core::intrinsics::simd::simd_cast|7","traitPath":null,"href":"../core/intrinsics/simd/fn.simd_cast.html","displayTypeSignature":{"type":["","T"," -> ","U"],"mappedNames":{},"whereClause":{}},"id":36082,"elems":[{"name":"T","id":-1,"typeFilter":26,"generics":[],"bindings":{},"fullPath":["t"],"pathLast":"t","normalizedPathLast":"t","pathWithoutLast":[]}],"returned":[{"name":"U","id":-2,"typeFilter":26,"generics":[],"bindings":{},"fullPath":["u"],"pathLast":"u","normalizedPathLast":"u","pathWithoutLast":[]}],"is_alias":false,"displayType":"`T` -> `U`","displayMappedNames":"T = T, U = U","displayWhereClause":""}'
Testing deduplication.js ... OK
Testing doc-alias-use.js ... OK
Testing enum-option.js ... OK
Testing exact-case.js ... OK
Testing field-is-unary-func.js ... OK
---
Testing struct-vec.js ... OK
Testing trait-unbox.js ... OK
Testing transmute-fail.js ... OK
Testing transmute.js ... FAILED
[ query `generic:T -> generic:U`]==> '{"path":"std::mem","name":"transmute"}' was supposed to be before '{"crate":"std","name":"simd_cast","path":"std::intrinsics::simd","exactPath":"core::intrinsics::simd","ty":7,"type":{"inputs":[{"id":-1,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"output":[{"id":-2,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"where_clause":[[],[]]},"paramNames":["T","U"],"dist":2,"path_dist":0,"index":-1,"desc":"Numerically casts a vector, elementwise.","item":{"id":36083,"crate":"std","ty":7,"name":"simd_cast","normalizedName":"simdcast","modulePath":"std::intrinsics::simd","exactModulePath":"core::intrinsics::simd","entry":{"krate":9305,"ty":7,"modulePath":15291,"exactModulePath":15288,"parent":null,"traitParent":null,"deprecated":false,"unstable":true,"associatedItemDisambiguator":null},"path":null,"functionData":{"functionSignature":{"inputs":[{"id":-1,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"output":[{"id":-2,"name":"","ty":26,"path":null,"exactPath":null,"generics":[],"bindings":{},"unboxFlag":true}],"where_clause":[[],[]]},"paramNames":["T","U"],"elemCount":2},"deprecated":false,"unstable":true,"parent":null,"traitParent":null},"displayPath":"<span>std::</span><span>intrinsics::</span><span>simd::</span>","fullPath":"core::intrinsics::simd::simd_cast|7","traitPath":null,"href":"../std/intrinsics/simd/fn.simd_cast.html","displayTypeSignature":{"type":["","T"," -> ","U"],"mappedNames":{},"whereClause":{}},"id":36083,"elems":[{"name":"T","id":-1,"typeFilter":26,"generics":[],"bindings":{},"fullPath":["t"],"pathLast":"t","normalizedPathLast":"t","pathWithoutLast":[]}],"returned":[{"name":"U","id":-2,"typeFilter":26,"generics":[],"bindings":{},"fullPath":["u"],"pathLast":"u","normalizedPathLast":"u","pathWithoutLast":[]}],"is_alias":false,"displayType":"`T` -> `U`","displayMappedNames":"T = T, U = U","displayWhereClause":""}'
Testing typed-query.js ... OK
Testing unbox-type-result.js ... OK
Testing vec-new.js ... OK
Testing vec-type-signatures.js ... OK
Testing write.js ... OK
Bootstrap failed while executing `--stage 2 test --skip compiler --skip src`
Command `/usr/bin/node /checkout/src/tools/rustdoc-js/tester.js --crate-name std --resource-suffix 1.93.0 --doc-folder /checkout/obj/build/aarch64-unknown-linux-gnu/doc --test-folder /checkout/tests/rustdoc-js-std` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/test.rs:1029:27
Executed at: src/bootstrap/src/core/build_steps/test.rs:1056:17

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:44:40
  local time: Sat Nov 29 19:01:19 UTC 2025
  network time: Sat, 29 Nov 2025 19:01:20 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

Copy link
Contributor

@notriddle notriddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple nit pick, but I think the release team would dislike a PR title that's backwards from the actual behavior.

The implementation itself seems okay.

View changes since this review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says it sorts unstable items first. This test seems to show the unstable item appearing last. Which is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants