Run clippy on cg_gcc in CI #149458
Open
Run clippy on cg_gcc in CI #149458
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
Collaborator
|
|
antoyo
reviewed
Nov 29, 2025
| --set llvm.libzstd=true \ | ||
| --set 'rust.codegen-backends=[\"llvm\",\"gcc\"]' | ||
| ENV SCRIPT python3 ../x.py \ | ||
| ENV SCRIPT python3 ../x.py --stage 2 clippy compiler/rustc_codegen_gcc && \ |
Contributor
There was a problem hiding this comment.
Does this test both with and without --no-default-features?
Member
Author
There was a problem hiding this comment.
No it doesn't. I can add that as a follow-up in the clippy rule.
Contributor
There was a problem hiding this comment.
It would be nice since the above issue would only happens without the master feature.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
clippy-cg_gcc
branch
from
8578319 to
43bd395
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
clippy-cg_gcc
branch
from
43bd395 to
0626c7a
Compare
Member
Author
|
Fixed bootstrap tests and CI is happy. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent this issue: in cg_gcc repository, we run clippy on our code but not in here, which can create issues.
cc @antoyo
r? @Kobzol