Fix for integer overflow in BinaryHeap for ZSTs #149451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Saphereye wants to merge 1 commit into rust-lang:main from Saphereye:binary_heap_integer_overflow

Saphereye commented Nov 29, 2025 •

edited by rustbot

Loading

This PR fixes a potential integer overflow while calculating the children of a node for a BinaryHeap for zero sized types.

rustbot assigned Mark-Simulacrum

rustbot added S-waiting-on-review T-libs labels

Collaborator

rustbot commented Nov 29, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

quaternic reviewed

View reviewed changes

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

quaternic reviewed

View reviewed changes

Contributor

quaternic left a comment •

edited by rustbot

Loading

I left some suggestions rephrasing comments, but with that this is looking good.

If you could then squash the commits, I think it will be ready to go.

View changes since this review

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved

library/alloc/src/collections/binary_heap/mod.rs Outdated Show resolved Hide resolved


          Refactored binary heap sift_down functions to avoid out of range access

0edddd2

Saphereye force-pushed the binary_heap_integer_overflow branch from 66c47bb to 0edddd2 Compare

December 1, 2025 13:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review T-libs