collapse constness query match logic

[fee1-dead]

We already have the HIR node data, so no need for asking def_kind again.

r? oli-obk

[rustbot]

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

[rustbot]

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

[fee1-dead]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: be2e6bc (be2e6bce7652ec2e3613195122bb1b55471268d1, parent: 1eb0657f78777f0b4d6bcc49c126d5d35212cae5)

[rust-timer]

Finished benchmarking commit (be2e6bc): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.886s -> 471.592s (-0.27%)
Artifact size: 386.93 MiB -> 386.92 MiB (-0.00%)

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[oli-obk]

@bors r+ rollup

Great find, this is so much better

[bors]

📌 Commit cf91330 has been approved by oli-obk

It is now in the queue for this repository.