-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Move the libgccjit.so file in a target directory #149426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since GCC is not multi-target, we need multiple libgccjit.so. Our solution to have a directory per target so that we can have multiple libgccjit.so.
|
This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp. Some changes occurred in compiler/rustc_codegen_gcc |
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1fea3d0 to
3dc76dc
Compare
|
This PR modifies |
This comment has been minimized.
This comment has been minimized.
|
@bjorn3: Is there any way to bless the UI tests for Aarch64 from an x86 computer? |
|
You can try if |
| //@ add-minicore | ||
| //@ compile-flags: --target thumbv8m.main-none-eabi --crate-type lib | ||
| //@ needs-llvm-components: arm | ||
| //@ ignore-backends: gcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these new test failures are due to the fact that --target is used and we now put libgccjit.so in a directory named after the target, so rustc_codegen_gcc doesn't find libgccjit.so.
Is this the correct way to ignore these tests?
Or are tests annotated with needs-llvm-compoments not expected to pass with a codegen that is not LLVM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think //@ ignore-backends: gcc makes sense. These tests would pass just fine with Cranelift if it is one of the targets supported by Cranelift. cg_clif always enables all backends of Cranelift.
Since GCC is not multi-target, we need multiple libgccjit.so. Our solution to have a directory per target so that we can have multiple libgccjit.so.
r? @Kobzol