Fix ICE when include_str! reads binary files

[reddevilmidzy]

ICE occurred when an invalid UTF8 file with an absolute path were included.

resolve: #149304

[reddevilmidzy]

Okay, the invalid bytes are all different..

[rustbot]

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[lcnr]

@rustbot reroll

[reddevilmidzy]

@rustbot ready

(tidy awesome...)

View changes since this review

[reddevilmidzy]

The ICE seemed to occur when reading an invalid binary file with an absolute path. So I used env like this to give an absolute path, but is there a better way?

[petrochenkov]

Why does it depend on the path?
I'd expect it to only depend on the file's contents.
What exactly cases of invalid UTF-8 trigger the bug?

[reddevilmidzy]

if I ran this code (use relative path)

#![doc = include_str!("invalid-utf8-binary-file.bin")] //~ ERROR: wasn't a utf-8 file

fn main() {}

diffrent error occur.

error: `invalid-utf8-binary-file.bin` wasn't a utf-8 file
  --> invalid-utf8-binary-file.bin:1:3
   |
LL | MZ�␀
   |   ^ byte `144` is not valid utf-8

error: aborting due to 1 previous error

ans ICE does not occur even if I do not modify compiler/rustc_parse/src/lib.rs

[petrochenkov]

I don't understand why source.normalized_source_len.0 can be less than start, because contents.len() should always be larger (or equal?) to start.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

..............................F
======== tests/rustdoc-gui/globals.goml ========

[ERROR] `tests/rustdoc-gui/globals.goml` line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}`


<= doc-ui tests done: 30 succeeded, 114 failed, 0 filtered out

Error: ()