-
Notifications
You must be signed in to change notification settings - Fork 14k
Offload bootstrap #148671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Offload bootstrap #148671
Conversation
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
|
@bors2 try @rust-timer queue (@Kobzol feel free to change if you want to see something else). |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 7069335 failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
|
@bors2 try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 31000c9 failed: CI. Failed jobs:
|
|
@bors2 try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Yes, we'd probably want them as a standalone build then.
stopping the rust build sounds tricky. So thinking more about it, I probably need to handle it all within |
|
Any reason you can't just do this in the same stage you build clang? Presumably that's already a dependency and uses the same LLVM checkout |
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 7f95fab failed: CI. Failed jobs:
|
|
I don't fully understand the motivation, but it's not the same checkout. What we do is:
I guess we could try building both runtimes against LLVM 21.1.0 and use it with the second LLVM 21.1.5, but that sounds like a risk, especially if they diverge more in the future. |
So disabling the LLVM tests with |
|
@bors2 try @rust-timer queue |
|
This pull request is already queued and waiting for a try build to finish. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 1cf5ae5 failed: CI. Failed jobs:
|
|
@bors2 try @rust-timer queue |
|
This pull request is already queued and waiting for a try build to finish. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for b623941 failed: CI. Failed jobs:
|
|
@bors2 try @rust-timer queue |
|
This pull request is already queued and waiting for a try build to finish. |
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for d35c1d3 failed: CI. Failed jobs:
|
The recommended way to build the offload project changed.
While already at it, testing how much overhead we get from building (or shipping) the two runtimes.
r? @Kobzol