constify result unwrap unchecked #148333
Merged
constify result unwrap unchecked #148333
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
clarfonthey
reviewed
Nov 1, 2025
| // SAFETY: the safety contract must be upheld by the caller. | ||
| Err(_) => unsafe { hint::unreachable_unchecked() }, | ||
| Err(e) => { | ||
| super::mem::forget(e); |
Contributor
There was a problem hiding this comment.
This should be annotated as a const hack so it can potentially be fixed later:
// FIXME(const-hack): to avoid E: const Destruct bound
bend-n
force-pushed
the
const_result_unwrap_unchecked
branch
from
05b1251 to
c15b256
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
const_result_unwrap_unchecked
branch
from
c15b256 to
991b449
Compare
Member
|
r=me with a tracking issue added |
Mark-Simulacrum
added
S-waiting-on-author
3 tasks
bend-n
force-pushed
the
const_result_unwrap_unchecked
branch
from
991b449 to
edd7d8a
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=mark-simulacrum |
Collaborator
|
@bend-n: 🔑 Insufficient privileges: Not in reviewers |
Member
|
@bors r=mark-simulacrum |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup of 22 pull requests Successful merges: - #128666 (Add `overflow_checks` intrinsic) - #146305 (Add correct suggestion for multi-references for self type in method) - #147179 ([DebugInfo] Fix container types failing to find template args) - #147743 (Show packed field alignment in mir_transform_unaligned_packed_ref) - #148079 (Rename `downcast_[ref|mut]_unchecked` -> `downcast_unchecked_[ref|mut]`) - #148084 (Optimize path components iteration on platforms that don't have prefixes) - #148126 (Fix rust stdlib build failing for VxWorks) - #148204 (Modify contributor email entries in .mailmap) - #148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names) - #148333 (constify result unwrap unchecked) - #148539 (Add Allocator proxy impls for Box, Rc, and Arc) - #148601 (`invalid_atomic_ordering`: also lint `update` & `try_update`) - #148612 (Add note for identifier with attempted hygiene violation) - #148613 (Switch hexagon targets to rust-lld) - #148619 (Enable std locking functions on AIX) - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`) - #148649 (don't completely reset `HeadUsages`) - #148673 (Remove a remnant of `dyn*` from the parser) - #148675 (Remove eslint-js from npm dependencies) - #148680 (Recover `[T: N]` as `[T; N]`) - #148688 (Remove unused argument `features` from `eval_config_entry`) - #148711 (Use the current lint note id when parsing `cfg!()`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup merge of #148333 - bend-n:const_result_unwrap_unchecked, r=mark-simulacrum constify result unwrap unchecked constifies unwrap unchecked on result will make tracking issue if good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constifies unwrap unchecked on result
will make tracking issue if good