-
Notifications
You must be signed in to change notification settings - Fork 14.1k
compiletest: Use //@ prefixes also for debuginfo test directives
#147799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
74887a7 to
1f5cd0c
Compare
//@ prefixes also for debuginfo test directives//@ prefixes also for debuginfo test directives
This comment has been minimized.
This comment has been minimized.
1f5cd0c to
9ec7434
Compare
|
@bors try jobs=x86_64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: x86_64-msvc-1
9ec7434 to
19de8a2
Compare
|
@bors try jobs=x86_64-msvc-1 |
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: x86_64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
x86_64-msvc-1 does not have cdb it seems, but I think aarch64 does: @bors try jobs=aarch64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 8aa08e9 failed: CI. Failed jobs:
|
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Luckily they were easy to resolve mechanically. |
|
r? saethlin @bors r+ rollup=never p=6 This will conflict with any change to the debuginfo tests |
…thlin compiletest: Use `//@` prefixes also for debuginfo test directives So that when we later add support for revisions we can use the same syntax for revisions as elsewhere (for #147426). This also prevents people from making typos for commands since `src/tools/compiletest/src/directives/directive_names.rs` will catch such typos now. Note that we add one FIXME for a non-trivial change for later: ``` // FIXME(#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure` ``` ### TODO - [x] Triple-check that all tests still run and all directives are still applied. Done: #147799 (comment) ### Zulip discussion https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.2F.2F.40.20syntax.20for.20debuginfo.20tests/with/545015582
|
💔 Test failed - checks-actions |
|
I can't see raw logs, which means a runner probably flaked out. @bors retry |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d8a7534 (parent) -> 6840234 (this PR) Test differencesShow 3 test diffs3 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6840234806e4a57e14112a1137783c885b7a23db --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (6840234): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -3.6%, secondary -4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 479.37s -> 469.478s (-2.06%) |
…thlin compiletest: Use `//@` prefixes also for debuginfo test directives So that when we later add support for revisions we can use the same syntax for revisions as elsewhere (for rust-lang/rust#147426). This also prevents people from making typos for commands since `src/tools/compiletest/src/directives/directive_names.rs` will catch such typos now. Note that we add one FIXME for a non-trivial change for later: ``` // FIXME(#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure` ``` ### TODO - [x] Triple-check that all tests still run and all directives are still applied. Done: rust-lang/rust#147799 (comment) ### Zulip discussion https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.2F.2F.40.20syntax.20for.20debuginfo.20tests/with/545015582
So that when we later add support for revisions we can use the same syntax for revisions as elsewhere (for #147426).
This also prevents people from making typos for commands since
src/tools/compiletest/src/directives/directive_names.rswill catch such typos now.Note that we add one FIXME for a non-trivial change for later:
TODO
//@prefixes also for debuginfo test directives #147799 (comment)Zulip discussion
https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.2F.2F.40.20syntax.20for.20debuginfo.20tests/with/545015582