Don't treat asserts as a call in cross-crate inlining

[saethlin]

Making functions with calls in their bodies automatically cross-crate-inlinable tends to tank incremental build times. Though assert terminators are like calls, they don't exhibit the same behavior.

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[saethlin]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 242d47d with merge 4729728...

[bors]

☀️ Try build successful - checks-actions
Build commit: 4729728 (47297289968ed393160d52bfca90a8d1c2e4c3c3)

[rust-timer]

Finished benchmarking commit (4729728): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[0.9%, 5.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-5.0%, -1.2%]	6
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	4

Bootstrap: missing data
Artifact size: 304.44 MiB -> 304.44 MiB (-0.00%)

[saethlin]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ffa51c9 with merge 4ddfadb...

[bors]

☀️ Try build successful - checks-actions
Build commit: 4ddfadb (4ddfadb5b5c09d7ac95df6ae8f0b15f9afc69aef)

[rust-timer]

Finished benchmarking commit (4ddfadb): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.1%, 4.0%]	4
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-0.9%	[-1.0%, -0.8%]	2
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.9%	[-1.0%, 4.0%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[1.4%, 5.1%]	5
Regressions ❌ (secondary)	2.5%	[1.2%, 5.0%]	8
Improvements ✅ (primary)	-3.2%	[-4.1%, -2.7%]	3
Improvements ✅ (secondary)	-2.1%	[-4.5%, -0.8%]	4
All ❌✅ (primary)	0.5%	[-4.1%, 5.1%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.8%, 4.3%]	4
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[-0.8%, 4.3%]	5

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 2.7%]	83
Regressions ❌ (secondary)	0.9%	[0.0%, 3.3%]	26
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	8
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	0.2%	[-0.3%, 2.7%]	91

Bootstrap: missing data
Artifact size: 304.48 MiB -> 304.49 MiB (0.00%)

[saethlin]

@bors try @rust-timer queue

[bors]

⌛ Trying commit dcde30d with merge c7f0427...

[bors]

☀️ Try build successful - checks-actions
Build commit: c7f0427 (c7f04272f0de8d2a5a62dce343201180175525d3)

[saethlin]

The try build finished after I force-pushed the change. test-various passes locally with the latest push.

@bors r=scottmcm

[bors]

📌 Commit daa77e6 has been approved by scottmcm

It is now in the queue for this repository.

[bors]

⌛ Testing commit daa77e6 with merge 64ebab8...

[bors]

💔 Test failed - checks-actions

[saethlin]

@bors try jobs=i686-msvc-1

[rust-bors]

💔 Test for 582ce2f failed: CI. Failed jobs:

• try - i686-msvc-1 (web logs, extended logs)

[saethlin]

@bors try jobs=i686-msvc-1

[saethlin]

@bors try cancel

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/19278879037

[saethlin]

@bors try jobs=i686-msvc-1,i686-msvc-2,x86_64-msvc-1,x86_64-msvc-2

[rust-bors]

💔 Test for 40a2216 failed: CI. Failed jobs:

• try - x86_64-msvc-1 (web logs, extended logs)

[saethlin]

#148849 Is the fix for the Windows tests I've been fighting with.