Skip to content

Fix empty_enum_variants_with_brackets misses removing brackets in patterns #16160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
profetia wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix empty_enum_variants_with_brackets misses removing brackets in patterns #16160

profetia wants to merge 2 commits into from
+232 −86

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Nov 30, 2025 •
edited by rustbot
Loading

Closes #16157

changelog: [empty_enum_variants_with_brackets] fix missing to remove brackets in patterns

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ada4a
ada4a suggested changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@ada4a ada4a left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this:) Some small suggestions

View changes since this review

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

Lintcheck changes for ddd328b

Lint Added Removed Changed
clippy::empty_enum_variants_with_brackets 0 0 1

This comment will be updated if you push new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ada4a ada4a ada4a requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samueltardieu samueltardieu

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

empty-enum-variants-with-brackets breaks code: expected tuple struct or tuple variant, found unit variant

4 participants

@profetia @rustbot @ada4a @samueltardieu