feat(unnecessary_fold): lint on folds with Add::add/Mul::mul
#16124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
Jarcho
requested changes
Nov 26, 2025
Comment on lines
45
to
55
| // - the final expression in the body of a function with a simple return type | ||
| if let hir::Node::Block(block) = parent | ||
| && let mut parents = cx.tcx.hir_parent_iter(block.hir_id).map(|(_, def_id)| def_id) | ||
| && let Some(hir::Node::Expr(_)) = parents.next() | ||
| && let Some(hir::Node::Item(enclosing_item)) = parents.next() | ||
| && let hir::ItemKind::Fn { sig, .. } = enclosing_item.kind | ||
| && let hir::FnRetTy::Return(fn_return_ty) = sig.decl.output | ||
| && matches!(fn_return_ty.kind, hir::TyKind::Path(..)) | ||
| { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
This and the previous checks are a subset of what using expr_use_ctxt would get you. You want something like:
if let Some(use_cx) = expr_use_ctxt(cx, expr)
&& use_cx.is_same_ctxt
&& let Some(ty) = use_cx.use_node(cx).defined_ty(cx)
{
// check ty
}
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for the tip! Changed
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
ada4a
force-pushed
the
unnecessary_fold
branch
from
92cad4a to
22d0416
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrects #13475
changelog: [
unnecessary_fold]: lint onfolds withAdd::add/Mul::mul