refactor(missing_asserts_for_indexing): overhaul diagnostics #16120
+114
−494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
Lintcheck changes for 129a39d
This comment will be updated if you push new changes |
Jarcho
requested changes
Nov 26, 2025
| diag.span_note(*span, "slice indexed here"); | ||
| } | ||
| diag.note("asserting the length before indexing will elide bounds checks"); | ||
| diag.span_labels(index_spans, "slice indexed here"); |
Contributor
There was a problem hiding this comment.
This label adds more noise than anything.
Contributor
Author
There was a problem hiding this comment.
Yeah, the lint spans are sufficient on their own now
Comment on lines
5
to
10
| | ^^^^ ^^^^ ^^^^ ^^^^ ^^^^ slice indexed here | ||
| | | | | | | ||
| | | | | slice indexed here | ||
| | | | slice indexed here | ||
| | | slice indexed here | ||
| | slice indexed here |
Contributor
There was a problem hiding this comment.
Per the previous. This is several lines cluttering the diagnostic while not adding new information.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This is a general advice, and so shouldn't be repeated
This makes the labels redundant.
ada4a
force-pushed
the
diag-missing_asserts_for_indexing
branch
from
bc76aef to
129a39d
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
missing_asserts_for_indexing]: overhaul diagnostics