Skip to content

Conversation

@RalfJung
Copy link
Member

This is required for working editor integration if the editor extension does not ship an RA binary itself.

The component is around 8.9 MiB in size, adding around 2.5% to the overall download size. So the question is, do we want to add this for everyone even though most people won't need it, or do we instead provide some other way for people to add more components to the miri toolchain? @rust-lang/miri what do you think?

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Nov 17, 2025
@RalfJung
Copy link
Member Author

@oli-obk @saethlin any preferences between these two options?

  • always install RA component, increases download size by 2.5%
  • add a mechanism for people to configure extra components that should be installed into the miri toolchain

@oli-obk
Copy link
Contributor

oli-obk commented Nov 21, 2025

The latter is probably generally useful.

Installing r-a will cater to the majority of ppl tho afaict, as only jetbrains users won't use it

@bjorn3
Copy link
Member

bjorn3 commented Nov 21, 2025

Vscode and Zed uses wouldn't use the rustup component either most certainly. Both ship/download the rust-analyzer executable independently from rustup unless you explicitly reconfigure them to use a specific executable.

@RalfJung
Copy link
Member Author

RalfJung commented Nov 21, 2025

The latter is probably generally useful.

Yeah, but it means we need a config file.

OTOH maybe we want a config file anyway to configure things like features so I don't have to pass --feature=genmc all the time when working on genmc.^^

@oli-obk
Copy link
Contributor

oli-obk commented Nov 21, 2025

Ok with that knowledge I think a miri.toml is probably best, yea

@saethlin
Copy link
Member

No objection, but as someone who doesn't even use r-a I don't really have anything to add. I've learned a few things from reading these comments ^^

@RalfJung RalfJung added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: Waiting for the PR author to address review comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants