-
Notifications
You must be signed in to change notification settings - Fork 410
Implement posix_fallocate with set_len() functionality
#4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement posix_fallocate with set_len() functionality
#4664
Conversation
|
Thank you for contributing to Miri! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
2d8cb4d to
21651ee
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Had to rebase because of the new |
|
@rustbot ready |
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just some minor nits. :)
|
@rustbot ready |
|
This looks great, thanks! Please squash the commits. You can squash manually if there are multiple independent commits you want to preserve, or use @rustbot author |
c573500 to
2ac2cf8
Compare
|
@rustbot ready |
should close #4464.
I used this man page for the implementation.
Changes included in this pr:
posix_fallocateandposix_fallocate64(same as truncate versions because of libc::off_t)unix/foreign_items.pass-dep/libc/libc-fs.rs.