Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Nov 24, 2025

most interesting piece for #1560 .

Using a safe approach for etag generation, without having to download or rewrite the HTML from storage.

I wasn't 100% certain about adding the dependency, let me know what you think :)

( alternative is to add serde::Serialize everywhere and using serde_json to serizlialize into the hash)

@syphar syphar self-assigned this Nov 24, 2025
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 24, 2025
@syphar syphar force-pushed the etag-rustdoc branch 7 times, most recently from c0dfd4c to dc39caf Compare November 26, 2025 17:38
@syphar syphar marked this pull request as ready for review November 26, 2025 17:56
@syphar syphar requested a review from a team as a code owner November 26, 2025 17:56
@syphar syphar changed the title WIP: add etag & conditional get to rustdoc html output add etag & conditional get to rustdoc html output Nov 26, 2025
@syphar
Copy link
Member Author

syphar commented Nov 26, 2025

@GuillaumeGomez this one can be reviewed now, will safe some time between browsers & cdn, but mainly between CDN & origin.

@syphar
Copy link
Member Author

syphar commented Nov 27, 2025

additional commits LGTM

@GuillaumeGomez GuillaumeGomez merged commit c0a977f into rust-lang:main Nov 27, 2025
13 checks passed
@GuillaumeGomez GuillaumeGomez deleted the etag-rustdoc branch November 27, 2025 09:38
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 27, 2025
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants