Skip to content

Conversation

@Gankra
Copy link

@Gankra Gankra commented Jun 18, 2025

Tentative blogpost for:

Info about when this will release is of course placeholder, and I'm happy to update the wording or add whatever details are desires.

Rendered

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be worth to talk about dynamic linking? i.e. to say that this doesn't affect people who link dynamically. But does it also increase the minimum musl version we support dynamic linking to? That's a tougher question. IDK whether we have to answer it, but if we know the answer, we should maybe write it down here.

The maintainers of musl themselves think that dynamic linking is an important way to use their libc, and it should be used for the musl based distros.

@alex
Copy link
Member

alex commented Jun 19, 2025

I think clarifying dynamical linking would be extremely valuable. My interest here is as someone who ships Python packages with Rust code that needs to adhere to the ABI for musl package (https://peps.python.org/pep-0656/). Host tools requiring a newer musl is fine, but crates compiled for these targets requiring a newer musl would have unclear impacts.

@workingjubilee
Copy link
Member

workingjubilee commented Jun 19, 2025

Hm. Notably, stdlib maintainers will need to know if we can use APIs that were only exposed by musl 1.2.4 and musl 1.2.5 for these targets, so we have a similar question as @alex.

rust-bors bot added a commit to rust-lang/rust that referenced this pull request Jun 19, 2025
Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: #107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
@Gankra
Copy link
Author

Gankra commented Jun 19, 2025

(I'll incorporate the various changes once I have the crater results and can do it all at once)

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
rust-timer added a commit to rust-lang/rust that referenced this pull request Nov 1, 2025
Rollup merge of #142682 - Gankra:update_musl_1.2.5, r=wesleywiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: #107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
@Kobzol
Copy link
Member

Kobzol commented Nov 1, 2025

Congratz on the PR being merged! 🎉 The change should get into 1.93, which will be stable on January 22. So we have a few weeks to publish this blog post.

@Gankra
Copy link
Author

Gankra commented Nov 18, 2025

The blogpost is now updated (it's publication date is wrong but I assume that's something y'all clean up at the end).

Co-authored-by: Jubilee <workingjubilee@gmail.com>
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 20, 2025
…, r=lqd

Fix platform supports docs tiny typo

This was noticed in rust-lang/blog.rust-lang.org#1641 (comment)

Thanks :)
rust-timer added a commit to rust-lang/rust that referenced this pull request Nov 21, 2025
Rollup merge of #149154 - apiraino:fix-platform-support-typo, r=lqd

Fix platform supports docs tiny typo

This was noticed in rust-lang/blog.rust-lang.org#1641 (comment)

Thanks :)
Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level, LGTM

@@ -0,0 +1,107 @@
+++
path = "2025/07/01/Updating-musl-1.2.5"
Copy link
Member

@jieyouxu jieyouxu Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark (for when we will be merging this): we'll need to bump this date to a more recent date :D

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this change and this blog post. Content mostly looks good, just a tone nit for the impacted gamedev project authors


At this point we expect there will be minimal breakage, and most breakage should be resolved by a `cargo update`. We believe this update shouldn't be held back any longer, as it contains critical fixes for the musl target.

Manual inspection of some of the affected projects indicates they largely haven't run `cargo update` in 2 years, often because they haven't had any changes in 2 years. Analysis suggests this Rust release will be a devastating blow to the thriving ecosystem of Rust gamedev projects that you started 3 years ago and will definitely get back to this year.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: this sentence comes across as a bit snarky to / dismissive of the authors of those gamedev projects. I would maybe just say something more neutral

Analysis of impacted projects suggests this Rust release will affect quite a few gamedev projects that have not run cargo update in several years.

Copy link
Contributor

@tgross35 tgross35 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative that I think also lightens things a bit:

...because they haven't had any changes in 2 years. (This may a problem for the gamedev project you started three years ago and will definitely get back to this year. When you do, just run cargo update.)


Manual inspection of some of the affected projects indicates they largely haven't run `cargo update` in 2 years, often because they haven't had any changes in 2 years. Analysis suggests this Rust release will be a devastating blow to the thriving ecosystem of Rust gamedev projects that you started 3 years ago and will definitely get back to this year.

Build failures from this change will typically look like "some \`extern\` functions couldn't be found; some native libraries may need to be installed or have their path specified", often specifically for "undefined reference to \`open64'", often while trying to build very old versions of the `getrandom` crate (hence the decimation of abandoned gamedev projects in particular):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: ditto above, maybe a slightly more neutral wording

Suggested change
Build failures from this change will typically look like "some \`extern\` functions couldn't be found; some native libraries may need to be installed or have their path specified", often specifically for "undefined reference to \`open64'", often while trying to build very old versions of the `getrandom` crate (hence the decimation of abandoned gamedev projects in particular):
Build failures from this change will typically look like "some \`extern\` functions couldn't be found; some native libraries may need to be installed or have their path specified", often specifically for "undefined reference to \`open64'", often while trying to build very old versions of the `getrandom` crate (hence the outsized impact on gamedev projects that haven't updated their dependencies in several years in particular):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants