backport #830 to rust-miniscript 10.x #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deriving keys we refuse to allow multipath keys. We should forbid them when directly constructing them at all.
apoelstra
force-pushed
the
2025-07-ddkey-0.10.x
branch
from
c213ab2 to
780d6bc
Compare
Member
Author
|
Successfully ran my local CI on 780d6bc |
Member
Author
|
This one is good to go once I have an ACK from you @sanket1729 . The 11.x one I am still hacking on my local CI, but you can see from the range-diff that this PR and #832 are identical, so if one is good then the other should be too. I will do some followup PRs, maybe tomorrow, which try to fix CI on 9.x, 10.x, 11.x and 12.x, since all these versions are used by software on crates.io. |
sanket1729
approved these changes
Jul 3, 2025
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
tACK 780d6bc.
Tested on my local machine on stable.
Member
Author
|
Tagged and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the logic fix; the error refactoring doesn't apply.