Backport #809 to 11.x #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these belong in lib.rs, but these in particular have been changed in rustc so that they now trigger on code that used to be okay. This prevents me from running tests with recent rustcs on backports.
Just runs `./generate-files.sh` after tweaking it to sort the list. Otherwise my local CI chokes on the inconsistency between different 'find' orderings.
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse as a string and then parse the keys. We fail to consider parsing errors in the keys, resulting in a panic. Also, clean up the panic message so it's clearer what's going on.
Member
Author
|
Successfully ran my local CI on this one. It's good to go. The failing checks are because we haven't pinned nightly here. |
Member
Author
|
cc @sanket1729 this one should be quick to review |
sanket1729
approved these changes
May 23, 2025
sanket1729
approved these changes
May 23, 2025
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
utACK 953e679
Sorry for the delay
Member
Author
|
Tagged and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #809 to 11.x. Last backport for this PR.