Skip to content

Added typesafe way to use a subclass of UITableViewCell #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrosen081 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added typesafe way to use a subclass of UITableViewCell #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Pods/Pods.xcodeproj/xcuserdata/jackrosen.xcuserdatad/xcschemes/xcschememanagement.plist
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added ...rTableViewKit.xcworkspace/xcuserdata/jackrosen.xcuserdatad/UserInterfaceState.xcuserstate
View file
Open in desktop
Binary file not shown.
14 changes: 14 additions & 0 deletions ...ableViewKit.xcodeproj/xcuserdata/jackrosen.xcuserdatad/xcschemes/xcschememanagement.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>SchemeUserState</key>
<dict>
<key>RSMasterTableViewKit.xcscheme_^#shared#^_</key>
<dict>
<key>orderHint</key>
<integer>0</integer>
</dict>
</dict>
</dict>
</plist>
2 changes: 1 addition & 1 deletion RSMasterTableViewKit/RSMasterTableViewKit/RSTableView/RSTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import UIKit

/// UITableViewCellConfiguration
public typealias UITableViewCellConfiguration<T> = ((_ cell: UITableViewCell, _ dataObject: T, _ indexPath: IndexPath) -> ())
public typealias UITableViewCellConfiguration<Cell: UITableViewCell, T> = ((_ cell: Cell, _ dataObject: T, _ indexPath: IndexPath) -> ())

/// Reusable TableViewCell
public protocol Reusable: class {
Expand Down
8 changes: 4 additions & 4 deletions RSMasterTableViewKit/RSMasterTableViewKit/RSTableView/RSTableViewDataSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ protocol RSTableViewDataSourceUpdate: class {
}

/// RSTableViewDataSource
open class RSTableViewDataSource<T>: NSObject, UITableViewDataSource {
open class RSTableViewDataSource<Cell: UITableViewCell, T>: NSObject, UITableViewDataSource {

// MARK: - Properties

Expand Down Expand Up @@ -96,7 +96,7 @@ open class RSTableViewDataSource<T>: NSObject, UITableViewDataSource {
private weak var dataSourceUpdateDelegate: RSTableViewDataSourceUpdate?

/// cell configuration - (cell, dataObject, indexPath)
private var cellConfiguration: UITableViewCellConfiguration<T>?
private var cellConfiguration: UITableViewCellConfiguration<Cell, T>?

/// cell identifier
private var cellIdentifier: String!
Expand All @@ -107,7 +107,7 @@ open class RSTableViewDataSource<T>: NSObject, UITableViewDataSource {

// MARK: - Initialize

public init(tableView: RSTableView, identifier: String, cellConfiguration: @escaping UITableViewCellConfiguration<T>) {
public init(tableView: RSTableView, identifier: String, cellConfiguration: @escaping UITableViewCellConfiguration<Cell, T>) {
super.init()

tableView.dataSource = self
Expand All @@ -128,7 +128,7 @@ open class RSTableViewDataSource<T>: NSObject, UITableViewDataSource {
public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {

// deque tableview cell
let cell = tableView.dequeueReusableCell(withIdentifier: self.cellIdentifier, for: indexPath)
let cell = tableView.dequeueReusableCell(withIdentifier: self.cellIdentifier, for: indexPath) as! Cell

// cell configuration
if let config = cellConfiguration {
Expand Down
14 changes: 14 additions & 0 deletions ...wKitExample.xcodeproj/xcuserdata/jackrosen.xcuserdatad/xcschemes/xcschememanagement.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>SchemeUserState</key>
<dict>
<key>RSMasterTableViewKitExample.xcscheme_^#shared#^_</key>
<dict>
<key>orderHint</key>
<integer>1</integer>
</dict>
</dict>
</dict>
</plist>