-
-
Notifications
You must be signed in to change notification settings - Fork 940
tests: Make known_failure more precise
#22366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5cbf1d to
061a46d
Compare
Contributor
|
Tests in It's because we expect on e.g. overflow panic message, but those don't exist in release. |
4b9b3d4 to
9f0469d
Compare
Contributor
Author
|
Added a commit to skip panicky tests if debug assertions are disabled; it's a little heavy-handed, as some panicky tests hit regular assertions, but we have few enough of those that I don't think it's a big deal. |
9f0469d to
e3fa7b4
Compare
Lord-McSweeney
approved these changes
Dec 1, 2025
This'll make it easier to tweak it in the future.
Tests that are expected to panic are now required to explicitely say so in their `test.toml`, by using `known_failure.panic = "expected message"`. Additionally, only panics raised during player ticking are caught, and not those happenning elsewhere (e.g. in rendering, or in test framework code).
Root-level `known_failure = true` now only except the trace output check to fail; if other checks (e.g. image comparisons) are expected to fail, they should specify their own `known_failure = true`.
e3fa7b4 to
dc5dd76
Compare
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Dec 3, 2025
------------------------------------------------------------------------------------- ppsspp.mk 0efae8fae18a6e5290f31fc27251e33e369cdc6f # Version: Commits on Dec 02, 2025 ------------------------------------------------------------------------------------- Merge pull request #21052 from falsepopsky/translations translation: update es_LA & es_ES, ------------------------------------------------------------------------------------ rpcs3.mk 3c747b377f8e7112cfe85ed3b2a8147a9946ca39 # Version: Commits on Dec 02, 2025 ------------------------------------------------------------------------------------ Qt: fix translation of update dialog if the language was changed between downloading the json and clicking on update, -------------------------------------------------------------------------------------- tsugaru.mk dc2671d5864970e8f467224313d3e6ca0326a0ca # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- Improved fidelity of FDC Seek command., ------------------------------------------------------------------------------------------- xenia-native.mk dd29365970e06a1e40b06714a8fed0fcfffbbd1d # Version: Commits on Dec 01, 2025 ------------------------------------------------------------------------------------------- [APU] Switched to New XMA decoder as default - Added codepath for \consume only\ pass. This should resolve constant clicking in Source engine games. - Added smaller performance improvements to decoder, --------------------------------------------------------------- ruffle.mk nightly-2025-12-02 # Version: Commits on Dec 02, 2025 --------------------------------------------------------------- ## What's Changed * chore: Run `npm audit fix` in `web` to fix security advisories by @torokati44 in ruffle-rs/ruffle#22383 * tests: Make `known_failure` more precise by @moulins in ruffle-rs/ruffle#22366 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-12-01...nightly-2025-12-02, -------------------------------------------------------------------------------------- scummvm.mk db31ebb24f2a07fe3020c80a02593166ec8e7b7b # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- BAGEL: METAGAME: Fix font size in notebook dialog, --------------------------------------------------------------------------------------- thextech.mk b4c0f0bce24682960ff9a971e2912abc1eadaddf # Version: Commits on Dec 02, 2025 --------------------------------------------------------------------------------------- macOS: Fixed an inability to make screenshots dir Unfortunately, the existing code just fails with the tilda begin on macOS, --------------------------------------------------------------------------------------------- deskpipro-case.mk cc1b2045231f2e4f5c93174c12dc8958bc300bfb # Version: Commits on Dec 02, 2025 --------------------------------------------------------------------------------------------- Update install-raspios-64bit.sh Update install-raspios-64bit.sh thanks Will 's tips (tech-n-code), -------------------------------------------------------------------------------------- aic8800.mk 80e7d448d9431f919860b3654f75500b06528c3f # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- fix: add fix-Lower-the-debugging-log-level.patch Signed-off-by: Feng Zhang <feng@radxa.com>, --------------------------------------------------------------------------------------- corsixth.mk 91d35f353b1759ad59e1c4e22d5c02b96d71485d # Version: Commits on Dec 02, 2025 --------------------------------------------------------------------------------------- Merge pull request #3153 from TheCycoONE/fix_ub_zero_memcopy Fix xmi write when called with an empty buffer, ---------------------------------------------------------------------------------------- openmohaa.mk 9168f32cdbb14b58d82cd70ffb3197895f82a0e3 # Version: Commits on Dec 01, 2025 ---------------------------------------------------------------------------------------- refactor(network): pack decimals based on the explicitly rounded value, ----------------------------------------------------------------------------------- rott.mk e34d9e976c8c904dd20f52363b82e681f881c13a # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------- disable player head tilting on landing, autoaim and falling (#131) * disable player head tilting on landing, autoaim and falling * adjust multiplicator, set normal horizon on mouselook switch, ---------------------------------------------------------------------------------- stk.mk 7df9411f5f4cd3f445fc65eb2740341baa76b57b # Version: Commits on Dec 01, 2025 ---------------------------------------------------------------------------------- Support setting the RTT scale via the command line, ---------------------------------------------------------------------------------------- supertux2.mk be106c73ebc02a6f5189b01f471aa9f77fc40398 # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------- Merge pull request #3422 from SuperTux/toggle-fancy-effects opengl: Fancy effects setting, ------------------------------------------------ re2c.mk 4.3.1 # Version: Commits on Dec 01, 2025 ------------------------------------------------ See [release notes](https://re2c.org/releases/release_notes.html#release-4-3-1) for details., ------------------------------------------------------- syncthing.mk v2.0.12 # Version: Commits on Dec 02, 2025 ------------------------------------------------------- ## Major changes in 2.0 - Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy. - The logging format has changed to use structured log entries (a message plus several key-value pairs). Additionally, we can now control the log level per package, and a new log level WARNING has been inserted between INFO and ERROR (which was previously known as WARNING...). The INFO level has become more verbose, indicating the sync actions taken by Syncthing. A new command line flag `--log-level` sets the default log level for all packages, and the `STTRACE` environment variable and GUI has been updated to set log levels per package. The `--verbose` and `--logflags` command line options have been removed and will be ignored if given. - Deleted items are no longer kept forever in the database, instead they are forgotten after fifteen months. If your use case require deletes to take effect after more than a fifteen month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing. - Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. Some options have been renamed, others have become subcommands. All serve options are now also accepted as environment variables. See `syncthing --help` and `syncthing serve --help` for details. - Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it. - A \default folder\ is no longer created on first startup. - Multiple connections are now used by default between v2 devices. The new default value is to use three connections: one for index metadata and two for data exchange. - The following platforms unfortunately no longer get prebuilt binaries for download at syncthing.net and on GitHub, due to complexities related to cross compilation with SQLite: - dragonfly/amd64 - solaris/amd64 - linux/ppc64 - netbsd/* - openbsd/386 and openbsd/arm - windows/arm - The handling of conflict resolution involving deleted files has changed. A delete can now be the winning outcome of conflict resolution, resulting in the deleted file being moved to a conflict copy. This release is also available as: * APT repository: https://apt.syncthing.net/ * Docker image: `docker.io/syncthing/syncthing:2.0.12` or `ghcr.io/syncthing/syncthing:2.0.12` (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version) ## What's Changed ### Other * chore: update quic-go, adapt to lack of write tracking by @calmh in syncthing/syncthing#10456 * chore(cli): clean up generated usage strings for config commands (fixes #10462) by @acolomb in syncthing/syncthing#10463 **Full Changelog**: syncthing/syncthing@v2.0.11...v2.0.12, ---------------------------------------------------------------------------------------- retroarch.mk 4d35ce17e50c10b0f185b9cd5f26a2076d1a0bf9 # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------- Windows fill_pathname_parent_dir_name start slash correction, -------------------------------------------------------------------------------------- vkquake.mk 9eaae2941d7ff6839d0e8a5d5b90798080519666 # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- MD3: Model-based naming, keep only 1 variant This is fallback for surface-based naming, keep only model_name.md3_S_X_Y.ext (0..S-1 surfaces, 0..X-1 skin, 0..Y-1 framgroup) with Legacy and MD5 style numberings, there are enough options as it is..., ----------------------------------------------------------------------------------------- sonic3-air.mk 651e8ceb3cdc0e51c736068cfe05b61eabc21379 # Version: Commits on Dec 01, 2025 ----------------------------------------------------------------------------------------- For Oxygen Engine app, use project-specific sub-folders in app data, ---------------------------------------------------------------------------------- trx.mk 1874da98c8eb53952199119989c34adf37b5be41 # Version: Commits on Dec 01, 2025 ---------------------------------------------------------------------------------- docs: update game-flow/Lua docs This adds various minor tweaks to the game flow and Lua documentation., ----------------------------------------------------------------------------------------------------- libretro-mame2003-plus.mk 198f6aa08c23afcea32821afaaa1938d4215df41 # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------------------------- Add files via upload, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 0efae8fae18a6e5290f31fc27251e33e369cdc6f # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #21052 from falsepopsky/translations translation: update es_LA & es_ES, ----------------------------------------------------------------------------------------------- libretro-scummvm.mk db31ebb24f2a07fe3020c80a02593166ec8e7b7b # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------------------- BAGEL: METAGAME: Fix font size in notebook dialog,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Requires PR #22348)
Instead of treating any error or panic as a success, only "expected" failures are allowed, and the kind of check that should fail must be specified:
known_failure = true: means that the final trace output check is expected to fail;known_failure.panic = "msg": means that the test is expected to panic (like the#[should_panic = "msg"]attribute in Rust unit tests);image_comparisons.NAME.known_failure = true: means that the given image check is expected to fail.