Fix crash when singleton types are passed to generic methods #355
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, TypeProf would crash with "unknown type variable: Elem" when
a class constant like `Array` or `Hash` was passed to methods like `all?`:
[].all?(Array) # => RuntimeError: unknown type variable: Elem
This happened because type parameters of Singleton types were not
registered in ty_env when resolving generic method signatures.
This commit fixes the issue by handling Type::Singleton in
get_instance_type, registering its type parameters with Source.new.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sinsoku
force-pushed
the
fix-singleton-type-params
branch
from
b4b3a5a to
3296d92
Compare
mame
approved these changes
Dec 23, 2025
Member
mame
left a comment
mame
left a comment
There was a problem hiding this comment.
Indeed... handling type parameters is difficult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TypeProf would crash with "unknown type variable: Elem" when
a class constant like
ArrayorHashwas passed to methods likeall?:This happened because type parameters of Singleton types were not
registered in ty_env when resolving generic method signatures.
This commit fixes the issue by handling Type::Singleton in
get_instance_type, registering its type parameters with Source.new.
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com