Skip to content

Fix crash in multiple Hash#merge! calls due to duplicate graph edges #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mame merged 2 commits into from
Dec 3, 2025
Merged

Fix crash in multiple Hash#merge! calls due to duplicate graph edges #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25a15d4
Fix crash in multiple Hash#merge! calls due to duplicate graph edges
pvcresin Nov 22, 2025
739d877
Fix the previous issue by `new_vertex` instead of duplication check
mame Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/typeprof/core/ast/sig_type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ def contravariant_vertex0(genv, changes, vtx, subst)
end

def typecheck(genv, changes, vtx, subst)
changes.add_edge(genv, vtx, subst[@var]) unless vtx == subst[@var]
changes.add_edge(genv, vtx.new_vertex(genv, self), subst[@var]) unless vtx == subst[@var]
true
end

Expand Down
22 changes: 22 additions & 0 deletions scenario/regressions/hash-merge-bang.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## update
def option
{ a: 1 }
end

def foo1
option.merge!(bar)
end

def foo2
option.merge!(bar)
end

def bar = {}

## assert
class Object
def option: -> Hash[:a, Integer]
def foo1: -> Hash[:a, Integer]
def foo2: -> Hash[:a, Integer]
def bar: -> Hash[untyped, untyped]
end