fix failure logging

Author: retailcoder

Rubberduck.Core/VersionCheck/VersionCheckService.cs

@@ -24,26 +24,22 @@ public VersionCheckService(Version version)
         private Version _latestVersion;
         public async Task<Version> GetLatestVersionAsync(GeneralSettings settings, CancellationToken token = default)
         {
-            if (_latestVersion != default) { return _latestVersion; }
+            if (_latestVersion != default) 
+            {
+                return _latestVersion; 
+            }
 
-            try
+            using (var client = new PublicApiClient())
             {
-                using (var client = new PublicApiClient())
-                {
-                    var tags = await client.GetLatestTagsAsync(token);
-                    var next = tags.Single(e => e.IsPreRelease).Name;
-                    var main = tags.Single(e => !e.IsPreRelease).Name;
+                var tags = await client.GetLatestTagsAsync(token);
+                var next = tags.Single(e => e.IsPreRelease).Name;
+                var main = tags.Single(e => !e.IsPreRelease).Name;
 
-                    var version = settings.IncludePreRelease
-                        ? next.Substring("Prerelease-v".Length)
-                        : main.Substring("v".Length);
+                var version = settings.IncludePreRelease
+                    ? next.Substring("Prerelease-v".Length)
+                    : main.Substring("v".Length);
 
-                    _latestVersion = new Version(version);
-                    return _latestVersion;
-                }
-            }
-            catch
-            {
+                _latestVersion = new Version(version);
                 return _latestVersion;
             }
         }