fix cancellation/timeout

Author: retailcoder

Rubberduck.Core/UI/Command/VersionCheckCommand.cs

@@ -5,6 +5,7 @@
 using Rubberduck.Resources;
 using Rubberduck.SettingsProvider;
 using Rubberduck.Settings;
+using System.Threading;
 
 namespace Rubberduck.UI.Command
 {
@@ -44,8 +45,10 @@ protected override async void OnExecute(object parameter)
         {
             var settings = _config.Read().UserSettings.GeneralSettings;
             Logger.Info("Executing version check...");
+
+            var tokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(5));
             await _versionCheck
-                .GetLatestVersionAsync(settings)
+                .GetLatestVersionAsync(settings, tokenSource.Token)
                 .ContinueWith(t =>
                 {
                     if (t.IsFaulted)

Rubberduck.Core/VersionCheck/PublicApiClient.cs

@@ -11,12 +11,9 @@ public class PublicApiClient : ApiClientBase
     {
         private static readonly string PublicTagsEndPoint = "public/tags";
 
-        public async Task<IEnumerable<Tag>> GetLatestTagsAsync()
+        public async Task<IEnumerable<Tag>> GetLatestTagsAsync(CancellationToken token)
         {
-            var tokenSource = new CancellationTokenSource();
-            tokenSource.CancelAfter(TimeSpan.FromSeconds(5));
-
-            return await GetResponse<Tag[]>(PublicTagsEndPoint, tokenSource.Token);
+            return await GetResponse<Tag[]>(PublicTagsEndPoint, token);
         }
     }
 }

Rubberduck.Core/VersionCheck/VersionCheckService.cs

@@ -30,7 +30,7 @@ public async Task<Version> GetLatestVersionAsync(GeneralSettings settings, Cance
             {
                 using (var client = new PublicApiClient())
                 {
-                    var tags = await client.GetLatestTagsAsync();
+                    var tags = await client.GetLatestTagsAsync(token);
                     var next = tags.Single(e => e.IsPreRelease).Name;
                     var main = tags.Single(e => !e.IsPreRelease).Name;