Skip to content

Commit 88477a8

Browse files
committed
clean up null propagation
1 parent 1a2482e commit 88477a8

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseEvaluation/UnreachableCaseInspector.cs

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,31 +98,26 @@ public UnreachableCaseInspector(
9898

9999
private UnreachableCaseInspection.CaseInspectionResultType? InvalidRangeExpressionsType(ICollection<IRangeClauseExpression> rangeClauseExpressions)
100100
{
101-
if (rangeClauseExpressions.Any(expr => expr?.IsMismatch ?? false))
101+
if (rangeClauseExpressions.Any(expr => expr?.IsMismatch == true))
102102
{
103103
return UnreachableCaseInspection.CaseInspectionResultType.MismatchType;
104104
}
105105

106-
if (rangeClauseExpressions.Any(expr => expr?.IsOverflow ?? false))
106+
if (rangeClauseExpressions.Any(expr => expr?.IsOverflow == true))
107107
{
108108
return UnreachableCaseInspection.CaseInspectionResultType.Overflow;
109109
}
110110

111-
if (rangeClauseExpressions.All(expr => expr?.IsInherentlyUnreachable ?? false))
111+
if (rangeClauseExpressions.All(expr => expr?.IsInherentlyUnreachable == true))
112112
{
113113
return UnreachableCaseInspection.CaseInspectionResultType.InherentlyUnreachable;
114114
}
115115

116116
if (rangeClauseExpressions.All(expr =>
117-
(expr?.IsUnreachable ?? false)
118-
|| (expr?.IsMismatch ?? false)
119-
|| (expr?.IsOverflow ?? false)
120-
|| (expr?.IsInherentlyUnreachable ?? false)))
117+
expr != null && (expr.IsUnreachable || expr.IsMismatch|| expr.IsOverflow || expr.IsInherentlyUnreachable))))
121118
{
122119
return UnreachableCaseInspection.CaseInspectionResultType.Unreachable;
123120
}
124-
125-
return null;
126121
}
127122

128123
private (UnreachableCaseInspection.CaseInspectionResultType? invalidValueType, VBAParser.CaseClauseContext caseClause) WithInvalidValueType(VBAParser.CaseClauseContext caseClause, IParseTreeVisitorResults parseTreeValues)

0 commit comments

Comments
 (0)