fix highlighting for multiline contexts, added ellipsis when truncated.

Author: retailcoder

Rubberduck.Parsing/Symbols/ArgumentReference.cs

@@ -52,11 +52,35 @@ internal ArgumentReference(
 
         public override (string context, Selection highlight) HighligthSelection(ICodeModule module)
         {
+            const int maxLength = 255;
+
             var lines = module.GetLines(Selection.StartLine, Selection.LineCount).Split('\n');
 
-            var line = lines[0]; // TODO think of something that makes sense for multiline
-            var indent = line.TakeWhile((c, i) => c.Equals(' ') && i < Selection.StartColumn).Count();
-            return (line.Trim(), new Selection(1, Math.Max(Selection.StartColumn - indent - 1, 1), 1, Math.Max(Selection.EndColumn - indent,1)).ToZeroBased());
+            var line = lines[0];
+            var indent = line.TakeWhile(c => c.Equals(' ')).Count();
+
+            var highlight = new Selection(
+                    1, Math.Max(Selection.StartColumn - indent, 1),
+                    1, Math.Max(Selection.EndColumn - indent, 1))
+                .ToZeroBased();
+
+            var trimmed = line.Trim();
+            if (trimmed.Length > maxLength || lines.Length > 1)
+            {
+                trimmed = trimmed.Substring(0, Math.Min(trimmed.Length, maxLength)) + "...";
+                highlight = new Selection(1, highlight.StartColumn, 1, trimmed.Length);
+            }
+
+            if (highlight.IsSingleCharacter && highlight.StartColumn == 0)
+            {
+                trimmed = " " + trimmed;
+                highlight = new Selection(0, 0, 0, 1);
+            }
+            else if (highlight.IsSingleCharacter)
+            {
+                highlight = new Selection(0, Selection.StartColumn-1 - indent - 1, 0, Selection.StartColumn-1 - indent);
+            }
+            return (trimmed, highlight);
         }
 
     }

Rubberduck.Parsing/Symbols/IdentifierReference.cs

@@ -135,11 +135,24 @@ public bool IsSelected(QualifiedSelection selection)
 
         public virtual (string context, Selection highlight) HighligthSelection(ICodeModule module)
         {
+            const int maxLength = 255;
+
             var lines = module.GetLines(Selection.StartLine, Selection.LineCount).Split('\n');
 
-            var line = lines[0]; // TODO think of something that makes sense for multiline
+            var line = lines[0];
             var indent = line.TakeWhile(c => c.Equals(' ')).Count();
-            return (line.Trim(), new Selection(1, Math.Max(Selection.StartColumn - indent,1), 1, Math.Max(Selection.EndColumn - indent,1)).ToZeroBased());
+
+            var highlight = new Selection(
+                1, Math.Max(Selection.StartColumn - indent, 1), 
+                1, Math.Max(Selection.EndColumn - indent, 1))
+            .ToZeroBased();
+
+            var trimmed = line.Trim();
+            if (trimmed.Length > maxLength || lines.Length > 1)
+            {
+                trimmed = trimmed.Substring(0, maxLength) + "...";
+            }
+            return (trimmed, highlight);
         }
 
         public bool Equals(IdentifierReference other)