build(rrvideo): upgrade playwright from 1.32.1 to 1.56.1 #1761
+21
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update playwright dependency to latest version and refactor test execution options to use a shared configuration with increased timeout for stability.
🦋 Changeset detectedLatest commit: 985e586 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Copilot finished reviewing on behalf of
Juice10
November 21, 2025 09:15
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Playwright dependency from version 1.32.1 to 1.56.1 and refactors test execution options to improve test stability and code maintainability.
- Playwright upgraded from 1.32.1 to 1.56.1 across package.json and yarn.lock
- Test execution options refactored to use a shared configuration object
- Added 60-second timeout to test executions for improved stability
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rrvideo/package.json | Updated playwright dependency to ^1.56.1 |
| yarn.lock | Updated playwright and playwright-core lock entries to 1.56.1, removed trailing whitespace |
| packages/rrvideo/test/cli.test.ts | Extracted shared execOptions configuration with timeout for consistent test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eoghanmurray
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update playwright dependency to latest version and refactor test execution options to use a shared configuration with increased timeout for stability.
I'm hoping that this will fix an issue related to the tests in #1637 timing out