Allow passing kwargs to yourdfpy.load_robot_description
#156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15748962655Details
💛 - Coveralls |
Member
|
Thank you for this proposal 👍 Regarding the defaults, I'd recommend we don't overriding upstream defaults (here the documentation of URDF.load states that One thing we could do is add a |
Contributor
Author
|
Oh, the kwargs is a better idea! I'll do that and update the changelog. |
sea-bass
changed the title
kwargs to load_robot_description
Contributor
Author
|
@stephane-caron Updated! |
sea-bass
force-pushed
the
toggle-load-scenes
branch
from
56b46f7 to
17de398
Compare
sea-bass
changed the title
kwargs to load_robot_descriptionkwargs to yourdfpy.load_robot_description
stephane-caron
merged commit 17de398
into
robot-descriptions:main
14 of 15 checks passed
Member
|
Merged, thank you for taking care of this 👍 |
Contributor
Author
Thank you! Looking forward to the next released version to use this. |
Member
|
On it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a small update to help solve this issue in Viser: nerfstudio-project/viser#483
Otherwise, the
yourdfpyloader in this package only ever loads visual meshes/scenes, but not the collision ones.I did default both parameters to true since it shouldn't hurt to always load everything by default, but let me know if this is not desired.