-
Notifications
You must be signed in to change notification settings - Fork 135
chore(site): pricing #3572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(site): pricing #3572
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Pricing Page UpdatesOverviewThis PR updates the pricing page and related documentation. The changes are primarily focused on the marketing website content with significant updates to the pricing page component and documentation files. Code QualityPositive Aspects✅ Well-structured React component - The Areas for Improvement1. Component Complexity (website/src/app/(v2)/(marketing)/pricing/PricingPageClient.tsx) The main component file is quite large (749 lines). Consider splitting into separate files: // Suggested structure:
/pricing
├── PricingPageClient.tsx (main orchestrator)
├── components/
│ ├── Hero.tsx
│ ├── ArchitectureExplainer.tsx
│ ├── CloudFeatures.tsx
│ ├── Pricing.tsx
│ ├── ComparisonTable.tsx
│ └── shared/
│ ├── Badge.tsx
│ ├── CodeBlock.tsx
│ └── FeatureCard.tsx2. TypeScript Type Safety Several components lack proper TypeScript typing: // Current (line 45):
const Badge = ({ text, color = "orange" }) => {
// Suggested:
interface BadgeProps {
text: string;
color?: 'orange' | 'blue' | 'red' | 'zinc';
}
const Badge: React.FC<BadgeProps> = ({ text, color = "orange" }) => {Same issue for 3. Hardcoded Values Multiple magic numbers and strings throughout: // Line 199: Hardcoded dimensions
<div className="relative h-[500px] w-full rounded-2xl...">
// Line 580-584: Pricing data should be in a separate config
const usagePricing = [
{ resource: "Active Actors", price: "$0.05", unit: "per 1k actor-hours" },
// ...
];Consider extracting to a configuration file for easier maintenance. 4. Animation Performance The drop animation (lines 273-278) uses CSS keyframes inline. Consider moving to a CSS module or styled-component for better performance and reusability. 5. Accessibility Improvements // Line 174: Button without aria-label
<button
onClick={() => document.getElementById('pricing')?.scrollIntoView({ behavior: 'smooth' })}
className="..."
>
// Suggested:
<button
onClick={() => document.getElementById('pricing')?.scrollIntoView({ behavior: 'smooth' })}
className="..."
aria-label="Scroll to pricing section"
>Documentation Changesllms-full.txt Updates:
Potential Issues:
Performance Considerations1. Component Re-renders const CloudFeatures = React.memo(() => {
// ... component code
});2. Bundle Size Security Concerns✅ No major security issues identified Minor consideration:
Testing RecommendationsSince this is a marketing page, consider:
Minor Issues1. Inconsistent spacing (website/src/components/Header.jsx:9 and Navigation.jsx:10) - href="https://dashboard.rivet.dev/"
+ href="https://dashboard.rivet.dev"Trailing slashes should be consistent across the codebase. 2. Date in blog post (website/src/posts/2025-11-02-weekly-updates/page.mdx) SummaryOverall Assessment: ✅ Approval with Suggestions This is solid work that significantly improves the pricing page presentation. The code is functional and follows React best practices. The main recommendations are around:
None of these are blocking issues, but they would improve maintainability for future updates. Action ItemsHigh Priority:
Medium Priority:
Low Priority:
Great work on this update! The pricing page looks much more polished and the documentation improvements are valuable additions. 🚀 |
More templates
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |
3a436d6 to
53544db
Compare
53544db to
17e711c
Compare
17e711c to
b16e2ae
Compare

No description provided.