refactor: switch to React Router #1115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderochervlk
force-pushed
the
vlk-v12-react-router
branch
from
3d98702 to
71c2897
Compare
Deploying rescript-lang-org with
|
| Latest commit: |
06e3824
|
| Status: | 🚫 Build failed. |
…ript-lang/rescript-lang.org into vlk-v12-react-router
…ript-lang/rescript-lang.org into vlk-v12-react-router
…nto vlk-v12-react-router
Collaborator
Author
Fixed. |
Collaborator
Author
Fixed. |
Member
there is a trailing |
Member
|
the prerequisites list is busted: https://vlk-v12-react-router.rescript-lang.pages.dev/docs/manual/installation |
jderochervlk
force-pushed
the
vlk-v12-react-router
branch
from
5f9563f to
472def8
Compare
jderochervlk
force-pushed
the
vlk-v12-react-router
branch
from
9cbd043 to
9041cbd
Compare
tsnobip
reviewed
Nov 14, 2025
| @@ -1534,23 +1536,37 @@ let make = (~bundleBaseUrl: string, ~versions: array<string>) => { | |||
| } | |||
| } | |||
|
|
|||
| let initialLang = switch Dict.get(router.query, (CompilerManagerHook.Ext :> string)) { | |||
| | Some("re") => Api.Lang.Reason | |||
| Console.log(("searchParams", searchParams)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.