Ffmpeg deep audit fixes #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed shebang lines (removed backslash escapes) - Fixed negation operators (! instead of \!) - Removed corrupted EOF markers at end of files - Fixed ARM64 architecture support in install-ffmpeg.sh - Ensured all scripts have proper executable permissions These scripts are critical for Docker container initialization and deployment verification.
Key fixes: - Fix service initialization: Use lazy imports in routers to avoid duplicate StorageService/QueueService instances that were never initialized - Fix worker/main.py: Replace settings.get() with getattr() for Pydantic Settings - Fix database password mismatch in compose.yml for worker services - Fix Docker resource limits in compose.override.yml (memory reservation < limit) - Add WORKER_TYPE setting to api/config.py - Add typing_extensions>=4.9.0 to requirements.txt - Add annotated_doc.py module for Doc annotation compatibility - Add batch processing migration (005_add_batch_columns.py) Affected routers updated to use get_storage_service()/get_queue_service(): - convert.py, batch.py, admin.py, health.py, jobs.py All changes tested with Docker Compose deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.