isPRCommit - Handle new URL format
#212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunsetTechuila
commented
Dec 16, 2025
index.ts
Outdated
Comment on lines
259
to
260
| 'https://github.com/sindresorhus/refined-github/pull/148/commits/0019603b83bd97c2f7ef240969f49e6126c5ec85', | ||
| 'https://github.com/sindresorhus/refined-github/pull/148/commits/00196', |
Contributor
Author
There was a problem hiding this comment.
These links are invalid
Contributor
Author
There was a problem hiding this comment.
Short hash should be at least 7 symbols
Member
There was a problem hiding this comment.
Out of curiosity I blamed it back to refined-github/refined-github#86. I wouldn't be surprised if 5 were enough back then and they upped the minimum lengthy since.
SunsetTechuila
changed the title
isPRCommit to handle new urlsisPRCommit to handle new URLs
fregante
changed the title
isPRCommit to handle new URLsisPRCommit - Handle new URL format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.