Skip to content

Conversation

@deerskindoll
Copy link
Contributor

@deerskindoll deerskindoll commented Oct 20, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):

main, release-1.8

Issue:

RHIDP-8629
Preview:

4. Sizing requirements for Red Hat Developer Hub

3. Configuring external PostgreSQL databases

Copy link
Member

@Fortune-Ndlovu Fortune-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this PR @deerskindoll, can we fix CI so I can also review the preview, otherwise looks good

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 28, 2025

@deerskindoll
Copy link
Contributor Author

@Fortune-Ndlovu sorry for the long response time, the preview is available now. I'm aware of the issue with additional text appears in the table. it's not in the source file and I'll be checking how to remove it from the preview

Copy link
Member

@Fortune-Ndlovu Fortune-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple, fix, the rest of the numbers look good, thanks.

Co-authored-by: Fortune Ndlovu <ndlovufortune97@gmail.com>
Copy link
Member

@Fortune-Ndlovu Fortune-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fix the syntax error within the table structure

Co-authored-by: Fortune Ndlovu <ndlovufortune97@gmail.com>
@deerskindoll
Copy link
Contributor Author

this should fix the syntax error within the table structure

thank you very much for the fix. I see that I didn't close the table properly

Copy link
Member

@Fortune-Ndlovu Fortune-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@deerskindoll deerskindoll added the Technical review done ⛅ Any procedure has been succesfully tested label Oct 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

New changes are detected. LGTM label has been removed.

Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.


.Prerequisites

* You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}]
* You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}].

I am afraid the user might have trouble navigating to the table in the mentioned section, making it difficult to find the information. Could we instead provide a direct link to the 4.2 table? If the table is already included in Sizing requirements for Red Hat Developer Hub, we can avoid repeating it.

Copy link
Contributor Author

@deerskindoll deerskindoll Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. let me check how to do it.

@themr0c can you please help me? the tables aren't separate modules, how do I link to them directly? do I have to move them to modules?


.Prerequisites

* You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}]
* You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}].

Same comment as above.

Co-authored-by: Judith Magak <124673476+jmagak@users.noreply.github.com>
@deerskindoll
Copy link
Contributor Author

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@deerskindoll: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Peer review needed 📖 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants