-
Notifications
You must be signed in to change notification settings - Fork 55
RHIDP-8629: sizing requirements for external PostgreSQL deployment with RHDH #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fortune-Ndlovu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this PR @deerskindoll, can we fix CI so I can also review the preview, otherwise looks good
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1449/ @ 11/06/25 12:06:05 |
|
@Fortune-Ndlovu sorry for the long response time, the preview is available now. I'm aware of the issue with additional text appears in the table. it's not in the source file and I'll be checking how to remove it from the preview |
Fortune-Ndlovu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple, fix, the rest of the numbers look good, thanks.
Co-authored-by: Fortune Ndlovu <ndlovufortune97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should fix the syntax error within the table structure
Co-authored-by: Fortune Ndlovu <ndlovufortune97@gmail.com>
thank you very much for the fix. I see that I didn't close the table properly |
Fortune-Ndlovu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
New changes are detected. LGTM label has been removed. |
jmagak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions.
|
|
||
| .Prerequisites | ||
|
|
||
| * You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}] | |
| * You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}]. |
I am afraid the user might have trouble navigating to the table in the mentioned section, making it difficult to find the information. Could we instead provide a direct link to the 4.2 table? If the table is already included in Sizing requirements for Red Hat Developer Hub, we can avoid repeating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. let me check how to do it.
@themr0c can you please help me? the tables aren't separate modules, how do I link to them directly? do I have to move them to modules?
|
|
||
| .Prerequisites | ||
|
|
||
| * You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}] | |
| * You meet the sizing requirements listed in Table 4.2 Recommended sizing for external PostgreSQL deployments with {product} in {product-docs-link}/single-html/about_red_hat_developer_hub/index#rhdh-sizing_about-rhdh[Sizing requirements for {product}]. |
Same comment as above.
Co-authored-by: Judith Magak <124673476+jmagak@users.noreply.github.com>
|
/cherry-pick release-1.8 |
|
@deerskindoll: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
main, release-1.8Issue:
RHIDP-8629
Preview:
4. Sizing requirements for Red Hat Developer Hub
3. Configuring external PostgreSQL databases