feat(tests): Add tests for gitops-must-gather #958

olivergondza · 2025-09-05T12:00:52Z

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test

/kind enhancement

/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Automate correctness and compatibility of the https://github.com/redhat-developer/gitops-must-gather/

Have you updated the necessary documentation?

[no] Documentation update is required by this PR.
[no] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

[no] Unit Test
[YES] E2E Test

How to test changes / Special notes to the reviewer:

To be tested as (local running operator): env LOCAL_RUN=true ./bin/ginkgo -v -focus "validate_running_must_gather" -r ./test/openshift/e2e/ginkgo/parallel/.

openshift-ci · 2025-09-05T12:01:05Z

Hi @olivergondza. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

olivergondza · 2025-09-05T12:02:30Z

test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go

+
+// MustGatherImage is a good place to insert development image
+// Known to be buggy in 1.17.0
+const MustGatherImage = "registry.redhat.io/openshift-gitops-1/must-gather-rhel8:v1.16.0" // TODO, use tag name with SUT version


For the purposes of verification:

Working: v1.16.0
Regression: v1.17.0
Test build for unpublished must-gather: quay.io/ogondza/gitops-must-gather:85ba0137a1f377113638862aebff971ecac2c10f

olivergondza · 2025-09-05T12:04:33Z

test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go

+
+			// TODO https://github.com/redhat-developer/gitops-must-gather/blob/135850b74b56b6fda9fc68ed4165a88b5c7dbeaf/gather_gitops.sh#L40
+			// TODO https://github.com/redhat-developer/gitops-must-gather/blob/135850b74b56b6fda9fc68ed4165a88b5c7dbeaf/gather_gitops.sh#L61
+			// TODO https://github.com/redhat-developer/gitops-must-gather/blob/135850b74b56b6fda9fc68ed4165a88b5c7dbeaf/gather_gitops.sh#L79


These are strictly speaking not needed now, but would achieve "full coverage" of the must gather script.

Any help installing given conditions in test cluster is appreciated. Thanks!

I am fine with leaving it like this. We can improve on it later, of if we see a regression in the future.

test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go

jgwest · 2025-09-08T13:28:06Z

/ok-to-test

olivergondza · 2025-09-08T20:05:57Z

Any idea why this pattern is failing only in this newely added test?

Error: test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go:31:2: ST1001: should not use dot imports (staticcheck)
215
	. "github.com/onsi/ginkgo/v2"
216
	^
217
Error: test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go:32:2: ST1001: should not use dot imports (staticcheck)
218
	. "github.com/onsi/gomega"
219
	^
220
2 issues:
221
* staticcheck: 2
222
make: *** [Makefile:364: lint] Error 1

https://github.com/redhat-developer/gitops-operator/actions/runs/17559040088/job/49870492021?pr=958

olivergondza · 2025-09-09T06:38:41Z

Following are failing for some seemingly unrelated reason:

ci/prow/v4.14-kuttl-parallel — Job failed.
ci/prow/v4.14-kuttl-sequential — Job failed.

/retest

olivergondza · 2025-09-09T07:42:24Z

/retest-required

olivergondza · 2025-09-09T12:35:36Z

/retest

olivergondza · 2025-09-25T18:50:35Z

/retest

olivergondza · 2025-09-29T07:32:29Z

/retest

olivergondza · 2025-10-29T10:35:42Z

/retest

olivergondza · 2025-10-30T08:41:24Z

@varshab1210, can you please review? Thanks!

olivergondza · 2025-11-05T10:29:57Z

Thanks for the review and verification, @AdamSaleh and @varshab1210.

Do you target particular time window to get this integrated? I would love to have this part of the next QE cycle...

New changes are detected. LGTM label has been removed.

Rebase to make things mergable. No new changes...

varshab1210 · 2025-11-10T09:44:22Z

/retest

varshab1210 · 2025-11-11T05:34:14Z

/retest

olivergondza · 2025-11-20T15:50:28Z

Gentle ping

varshab1210 · 2025-11-27T09:58:53Z

/lgtm

varshab1210 · 2025-11-27T09:59:04Z

/lgtm

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

…o memory + please gosec Signed-off-by: Oliver Gondža <ogondza@gmail.com>

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

varshab1210 · 2025-11-27T10:46:56Z

/lgtm

olivergondza · 2025-11-27T10:55:55Z

/retest

varshab1210 · 2025-11-27T11:02:55Z

/test v4.14-images

openshift-ci · 2025-11-27T11:03:15Z

@olivergondza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.17-ci-index-gitops-operator-bundle	`66e9085`	link	true	`/test v4.17-ci-index-gitops-operator-bundle`
ci/prow/v4.17-kuttl-sequential	`66e9085`	link	true	`/test v4.17-kuttl-sequential`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

varshab1210 · 2025-11-27T12:52:39Z

/test v4.14-images

* feat(tests): Add tests for gitops-must-gather Signed-off-by: Oliver Gondža <ogondza@gmail.com> * feat(tests): validate_running_must_gather.go: permit image override Signed-off-by: Oliver Gondža <ogondza@gmail.com> * fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec Signed-off-by: Oliver Gondža <ogondza@gmail.com> * chore(test): Static analysis fixes Signed-off-by: Oliver Gondža <ogondza@gmail.com> * fix(tests): Suppress checking files not present in older ocp versions Signed-off-by: Oliver Gondža <ogondza@gmail.com> --------- Signed-off-by: Oliver Gondža <ogondza@gmail.com> Signed-off-by: akhil nittala <nakhil@redhat.com>

openshift-ci bot added the kind/enhancement New feature or request label Sep 5, 2025

openshift-ci bot requested review from jannfis and varshab1210 September 5, 2025 12:00

openshift-ci bot added the needs-ok-to-test label Sep 5, 2025

olivergondza commented Sep 5, 2025

View reviewed changes

test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go Outdated Show resolved Hide resolved

openshift-ci bot added ok-to-test and removed needs-ok-to-test labels Sep 8, 2025

olivergondza force-pushed the test-for-must-gather branch 2 times, most recently from d1e92f0 to 84b1c7c Compare September 8, 2025 17:30

olivergondza force-pushed the test-for-must-gather branch from 84b1c7c to 5087629 Compare September 9, 2025 12:30

olivergondza force-pushed the test-for-must-gather branch 2 times, most recently from 62d322e to 39b85fd Compare September 10, 2025 06:33

olivergondza mentioned this pull request Sep 11, 2025

docs: Document new verification routines redhat-developer/gitops-must-gather#38

Open

2 tasks

olivergondza force-pushed the test-for-must-gather branch 3 times, most recently from 66e9085 to 9cb873c Compare September 16, 2025 19:06

olivergondza force-pushed the test-for-must-gather branch from 9cb873c to 962d2e7 Compare September 25, 2025 12:29

olivergondza force-pushed the test-for-must-gather branch from 962d2e7 to 3276377 Compare October 27, 2025 12:25

olivergondza force-pushed the test-for-must-gather branch from 3276377 to 22167e6 Compare November 5, 2025 10:05

openshift-ci bot removed the lgtm label Nov 5, 2025

olivergondza force-pushed the test-for-must-gather branch from 22167e6 to 2d91edb Compare November 20, 2025 15:50

varshab1210 closed this Nov 27, 2025

varshab1210 reopened this Nov 27, 2025

openshift-merge-robot added the needs-rebase label Nov 27, 2025

openshift-ci bot added the lgtm label Nov 27, 2025

olivergondza added 5 commits November 27, 2025 11:43

feat(tests): Add tests for gitops-must-gather

f8de884

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

feat(tests): validate_running_must_gather.go: permit image override

783cb21

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

fix(tests): 1-120_validate_running_must_gather.go: Do not read file t…

447538d

…o memory + please gosec Signed-off-by: Oliver Gondža <ogondza@gmail.com>

chore(test): Static analysis fixes

97aba6b

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

fix(tests): Suppress checking files not present in older ocp versions

650990e

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

olivergondza force-pushed the test-for-must-gather branch from 2d91edb to 650990e Compare November 27, 2025 10:45

openshift-ci bot removed the lgtm label Nov 27, 2025

openshift-merge-robot removed the needs-rebase label Nov 27, 2025

openshift-ci bot added the lgtm label Nov 27, 2025

openshift-merge-bot bot merged commit 0755156 into redhat-developer:master Nov 27, 2025
16 checks passed

olivergondza deleted the test-for-must-gather branch November 27, 2025 15:55

feat(tests): Add tests for gitops-must-gather #958

feat(tests): Add tests for gitops-must-gather #958

Uh oh!

Conversation

olivergondza commented Sep 5, 2025

Uh oh!

openshift-ci bot commented Sep 5, 2025

Uh oh!

olivergondza Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

olivergondza Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdamSaleh Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jgwest commented Sep 8, 2025

Uh oh!

olivergondza commented Sep 8, 2025

Uh oh!

olivergondza commented Sep 9, 2025

Uh oh!

olivergondza commented Sep 9, 2025

Uh oh!

olivergondza commented Sep 9, 2025

Uh oh!

olivergondza commented Sep 25, 2025

Uh oh!

olivergondza commented Sep 29, 2025

Uh oh!

olivergondza commented Oct 29, 2025

Uh oh!

olivergondza commented Oct 30, 2025

Uh oh!

olivergondza commented Nov 5, 2025

Uh oh!

varshab1210 commented Nov 10, 2025

Uh oh!

varshab1210 commented Nov 11, 2025

Uh oh!

olivergondza commented Nov 20, 2025

Uh oh!

varshab1210 commented Nov 27, 2025

Uh oh!

varshab1210 commented Nov 27, 2025

Uh oh!

varshab1210 commented Nov 27, 2025

Uh oh!

olivergondza commented Nov 27, 2025

Uh oh!

varshab1210 commented Nov 27, 2025

Uh oh!

openshift-ci bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varshab1210 commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

olivergondza Sep 5, 2025 •

edited

Loading

openshift-ci bot commented Nov 27, 2025 •

edited

Loading