Skip to content

Conversation

@rocrisp
Copy link
Contributor

@rocrisp rocrisp commented Dec 1, 2025

Fixes #3293
Implements new test to ensure Deployments using TopologySpreadConstraints include both hostname and zone topology keys to avoid manual PDB tweaking during platform upgrades.

Test Details:

  • Pass: TSC not defined OR both hostname+zone keys present
  • Fail: TSC defined but missing either key
  • Skips: SNO and compact clusters (not enough workers)
  • Classification: Telco (Mandatory), Others (Optional)
  • Tags: telco, lifecycle

Files Modified:

  • tests/lifecycle/suite.go: Test implementation
  • tests/identifiers/identifiers.go: Test identifier
  • tests/identifiers/impact.go: Impact statement
  • tests/identifiers/remediation.go: Remediation guidance
  • tests/identifiers/doclinks.go: Documentation link
  • expected_results.yaml: Added to skip list
  • CATALOG.md: Test catalog entry (auto-generated)

@rocrisp rocrisp requested review from bnshr and sebrandon1 December 1, 2025 23:49
@dcibot
Copy link
Collaborator

dcibot commented Dec 2, 2025

Implements new test to ensure Deployments using TopologySpreadConstraints
include both hostname and zone topology keys to avoid manual PDB tweaking
during platform upgrades.

Test Details:
- Pass: TSC not defined OR both hostname+zone keys present
- Fail: TSC defined but missing either key
- Skips: SNO and compact clusters (not enough workers)
- Classification: Telco (Mandatory), Others (Optional)
- Tags: telco, lifecycle

Files Modified:
- tests/lifecycle/suite.go: Test implementation
- tests/identifiers/identifiers.go: Test identifier
- tests/identifiers/impact.go: Impact statement
- tests/identifiers/remediation.go: Remediation guidance
- tests/identifiers/doclinks.go: Documentation link
- expected_results.yaml: Added to skip list
- CATALOG.md: Test catalog entry (auto-generated)
@rocrisp rocrisp force-pushed the feature/lifecycle-topology-spread-constraint branch from ca143fe to ee05394 Compare December 2, 2025 01:09
@dcibot
Copy link
Collaborator

dcibot commented Dec 2, 2025

Copy link
Contributor

@greyerof greyerof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @rocrisp!

Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@sebrandon1
Copy link
Member

/dci-rerun

@dcibot
Copy link
Collaborator

dcibot commented Dec 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal for new test case for pod's TopologySpreadConstraint in MNO Clusters

4 participants