-
-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Always populate relativePath for access across browser and electron #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
saul-prepared
wants to merge
3
commits into
react-dropzone:master
from
saul-prepared:feature/relative-path
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,8 +87,8 @@ export const COMMON_MIME_TYPES = new Map([ | |
|
|
||
| export function toFileWithPath(file: FileWithPath, path?: string): FileWithPath { | ||
| const f = withMimeType(file); | ||
| const {webkitRelativePath} = file; | ||
| if (typeof f.path !== 'string') { // on electron, path is already set to the absolute path | ||
| const {webkitRelativePath} = file; | ||
| Object.defineProperty(f, 'path', { | ||
| value: typeof path === 'string' | ||
| ? path | ||
|
|
@@ -104,11 +104,27 @@ export function toFileWithPath(file: FileWithPath, path?: string): FileWithPath | |
| }); | ||
| } | ||
|
|
||
| // Always populate a relative path so that even electron apps have access to a relativePath value | ||
| Object.defineProperty(f, 'relativePath', { | ||
| value: typeof path === 'string' | ||
| ? path | ||
| // If <input webkitdirectory> is set, | ||
| // the File will have a {webkitRelativePath} property | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory | ||
| : typeof webkitRelativePath === 'string' && webkitRelativePath.length > 0 | ||
| ? webkitRelativePath | ||
| : `/${file.name}`, // prepend forward slash (/) to ensure consistancy when path isn't supplied. | ||
| writable: false, | ||
| configurable: false, | ||
| enumerable: true | ||
| }) | ||
|
Comment on lines
+108
to
+120
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not too different from setting the path. Let's make this block a function and reuse it for setting the Also, since the path is relative, |
||
|
|
||
| return f; | ||
| } | ||
|
|
||
| export interface FileWithPath extends File { | ||
| readonly path?: string; | ||
| readonly relativePath?: string; | ||
| } | ||
|
|
||
| function withMimeType(file: FileWithPath) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolandjitsu I changed this to still call fromDataTransferItem while still getting the functionality I need.