Skip to content

Conversation

@jonkoops
Copy link
Collaborator

@jonkoops jonkoops commented Nov 4, 2024

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Adds Prettier as a code formatter. This is a follow up of #102 which should be merged first.

Does this PR introduce a breaking change?
No.

Other information
Not applicable.

@jonkoops jonkoops changed the title Prettier chore: add Prettier to format code Nov 4, 2024
@coveralls
Copy link

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11742151110

Details

  • 91 of 91 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11704355753: 0.0%
Covered Lines: 93
Relevant Lines: 93

💛 - Coveralls

@jonkoops jonkoops force-pushed the prettier branch 2 times, most recently from e5cc052 to af70a16 Compare November 6, 2024 17:49
@jonkoops jonkoops marked this pull request as ready for review November 6, 2024 17:59
@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 6, 2024

Marking this one as ready to review, let me know what you think @rolandjitsu

@jonkoops jonkoops requested a review from rolandjitsu November 6, 2024 17:59
@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 6, 2024

Follow up PR to add lint-staged and Husky is up under #105

@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 7, 2024

@rolandjitsu could we merge this one in? I have a couple of follow ups in the pipeline.

Copy link
Collaborator

@rolandjitsu rolandjitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had those couple of comments. It LGTM otherwise.

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 8, 2024

@rolandjitsu processed the review, could you give it another pass?

@rolandjitsu rolandjitsu merged commit 5a3544f into react-dropzone:beta Nov 9, 2024
6 checks passed
@jonkoops jonkoops deleted the prettier branch November 9, 2024 10:32
@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 9, 2024

Thanks for the merge, I'll start re-basing the other PRs on top :)

@github-actions
Copy link

🎉 This PR is included in version 3.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants