First tests and first bug found and fixed. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started writing tests (canBUyWeapon method)
radduC
reviewed
Jun 7, 2024
radduC
reviewed
Jun 7, 2024
|
|
||
| public static boolean winProbability(PlayerStatus opponent, int health, int score) { | ||
| @Override | ||
| public boolean myWinProbability(PlayerStatus opponent, int health, int score) { |
Collaborator
There was a problem hiding this comment.
Refactor this to use PlayerStatus opponent1, PlayerStatus opponent2 as parameters instead, to be more clear.
radduC
requested changes
Jun 7, 2024
| @Override | ||
| public boolean myWinProbability(PlayerStatus opponent, int health, int score) { | ||
| var opponentWinProb = (3 * opponent.getHealth() + opponent.getScore() / 1000) / 4; | ||
| var myWinProb = (3 * health + score / 1000) / 4; |
Collaborator
There was a problem hiding this comment.
Create another method that calculates win prob. taking a PlayerStatus player as parameter and use it here instead.
| public boolean shouldAttackOpponent(PlayerStatus opponent) { | ||
| if (opponent.getWeaponInHand() == weaponInHand) { | ||
| return winProbability(opponent, health, score); | ||
| return service.myWinProbability(opponent, health, score); |
Collaborator
There was a problem hiding this comment.
Refactor this to use as parameters (this, opponent) instead.
radduC
reviewed
Jun 7, 2024
radduC
reviewed
Jun 7, 2024
radduC
reviewed
Jun 7, 2024
radduC
reviewed
Jun 7, 2024
razvanexu
commented
Jun 10, 2024
Owner
Author
razvanexu
left a comment
razvanexu
left a comment
There was a problem hiding this comment.
Please review my latest refactoring
radduC
approved these changes
Jun 11, 2024
Collaborator
|
Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.