Skip to content

Conversation

@rsbh
Copy link
Member

@rsbh rsbh commented Dec 10, 2025

Description

This PR adds a new package called tools-configs which will contain config for multiple tools of this monorepo.
The tools-configs package will also be published to npm and used in other repos like raystack/frontier, etc.
Only the biome and ts-config have been added. We will add more configs like rollup, vite, and vitest in the future.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

[Describe the tests that you ran to verify your changes]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Screenshots (if appropriate):

[Add screenshots here]

Related Issues

[Link any related issues here using #issue-number]

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
apsara Ready Ready Preview, Comment Dec 16, 2025 6:00am

@paanSinghCoder
Copy link
Contributor

I still think pkg name should be tools-config instead of tools-configs 😂😂 but overall looks good.

@rsbh
Copy link
Member Author

rsbh commented Dec 16, 2025

I still think pkg name should be tools-config instead of tools-configs 😂😂 but overall looks good.

@paanSinghCoder I have updated the name

Copy link
Contributor

@rohanchkrabrty rohanchkrabrty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release it on every apsara release? I feel it's better to create a workflow and trigger release

@rsbh
Copy link
Member Author

rsbh commented Dec 17, 2025

Should we release it on every apsara release? I feel it's better to create a workflow and trigger release

Yes, Lots of monorepos bump version of packages even if there is no change.

@rsbh rsbh merged commit 488f1b9 into main Dec 17, 2025
4 checks passed
@rsbh rsbh deleted the feat_common_tools_configs branch December 17, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants