-
Notifications
You must be signed in to change notification settings - Fork 7k
[Docs] Update KubeRay & Volcano integration document #59636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the KubeRay & Volcano integration documentation. The changes correctly remove all references to the deprecated ray.io/scheduler-name: volcano label, which is no longer needed for scheduler configuration. The documentation is updated with a clear note explaining this change and now reflects the current practice of configuring the scheduler at the operator level. The PR also beneficially adds documentation for new Volcano labels related to network topology and clarifies the gang scheduling behavior with autoscaling. The updates are accurate and improve the clarity of the document for users.
|
Hi @win5923 @Future-Outlier , please take a look when you have a chance. Thank you! |
Signed-off-by: seanlaii <qazwsx0939059006@gmail.com>
440fee3 to
f29adb8
Compare
| ``` | ||
|
|
||
| You can also be provide the following labels in the RayCluster metadata: | ||
| You can also provide the following labels in the RayCluster and RayJob metadata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and RayService?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't support RayService IIUC. I can help if we would like to support it.
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @win5923 to take a look, thank you!
Description
Previously, the
ray.io/scheduler-namelabel was used to determine the scheduler for KubeRay CRDs. However, with the adoption of the new scheduler framework, the scheduler name is now configured via the controller configuration,--batch-scheduler, and the label is no longer needed.Therefore, we can remove the information related to
ray.io/scheduler-nameto avoid ambiguity.Related issues
Related to ray-project/kuberay#4305
Additional information