-
Notifications
You must be signed in to change notification settings - Fork 2k
Accessibility tweaks #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility tweaks #4206
Conversation
jekyll-assets/css/style.css
Outdated
| background: transparent; | ||
| } | ||
|
|
||
| h2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to be a bit defensive here, is it worth scoping to #docs-header or even putting this on #docs-header-title directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put it on docs-header. I didn't want to be too specific as there is an overriding 1.9em on the more specific item that I want to apply, but my browser was multiplying this with a 1.5em from somewhere. I think I needed the initial to clear that 1.5em.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, em is a relative unit so it is affected by the parent font size, see https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/Styling_basics/Values_and_units#numbers_lengths_and_percentages. (This is why we prefer using rem for the rest of the site.)
No description provided.