Skip to content

Allows the Valve to be used with Tomcat 10 by using the jakarta namespace #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ecolinet-orange wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allows the Valve to be used with Tomcat 10 by using the jakarta namespace #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3131b0f
Allow the use of Tomcat 10 using the jakarta namespace
ecolinet-orange Dec 10, 2024
0c03d74
Use java 1.8
ecolinet-orange Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,18 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.7</java.version>
<java.version>1.8</java.version>

<jedis.version>3.0.1</jedis.version>
<commons-pool2.version>2.6.2</commons-pool2.version>
<slf4j-api.version>1.7.26</slf4j-api.version>

<maven-compiler.version>3.6.1</maven-compiler.version>
<source-java.version>1.7</source-java.version>
<source-java.version>1.8</source-java.version>
<target-java.version>${source-java.version}</target-java.version>

<!-- For local development properties begins.. -->
<tomcat.version>8.5.32</tomcat.version>
<tomcat.version>10.1.33</tomcat.version>
<!-- For local development properties end.. -->
</properties>

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/tomcat/request/session/redis/SessionHandlerValve.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import org.slf4j.LoggerFactory;
import tomcat.request.session.exception.BackendException;

import javax.servlet.ServletException;
import jakarta.servlet.ServletException;
import java.io.IOException;

/** author: Ranjith Manickam @ 12 Jul' 2018 */
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/tomcat/request/session/redis/SingleSignOnValve.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
import tomcat.request.session.exception.BackendException;
import tomcat.request.session.model.SingleSignOnEntry;

import javax.servlet.ServletException;
import javax.servlet.http.Cookie;
import jakarta.servlet.ServletException;
import jakarta.servlet.http.Cookie;
import java.io.IOException;
import java.security.Principal;
import java.util.Set;
Expand Down
20 changes: 10 additions & 10 deletions src/test/java/tomcat/request/session/redis/SessionManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
import java.util.Date;
import java.util.Enumeration;

import javax.servlet.ServletException;
import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
import jakarta.servlet.ServletException;
import jakarta.servlet.annotation.WebServlet;
import jakarta.servlet.http.HttpServlet;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import jakarta.servlet.http.HttpSession;

@WebServlet("/")
public class SessionManagerTest extends HttpServlet {
Expand Down Expand Up @@ -44,7 +44,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)

/**
* method to send response
*
*
* @param response
* @param responseData
* @throws IOException
Expand All @@ -57,7 +57,7 @@ private void sendResponse(HttpServletResponse response, String responseData) thr

/**
* method to get actions
*
*
* @param request
* @return
*/
Expand Down Expand Up @@ -95,7 +95,7 @@ private String getActions(HttpServletRequest request) {

/**
* method to set session values
*
*
* @param session
* @return
*/
Expand All @@ -108,7 +108,7 @@ private String setSessionValues(HttpSession session) {

/**
* method to get session values
*
*
* @param session
* @param action
* @return
Expand Down