-
-
Notifications
You must be signed in to change notification settings - Fork 61
deps: update deps #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update deps #971
Conversation
|
⏳ Code review in progress. Analyzing for code quality issues and best practices. Detailed findings will be posted upon completion. Using Amazon Q Developer for GitHubAmazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation. Slash Commands
FeaturesAgentic Chat Code Review CustomizationYou can create project-specific rules for Amazon Q Developer to follow:
Example rule: FeedbackTo provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository. For more detailed information, visit the Amazon Q for GitHub documentation. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency Update Review
This PR updates several key dependencies:
- pre-commit-hooks: v5.0.0 → v6.0.0 (major version bump)
- Ruff linter: v0.12.7 → v0.12.11
- AWS CDK: 2.1023.0 → 2.1027.0
- Various Poetry dependencies
Recommendations before merging:
- Run the full test suite to ensure compatibility with the new versions
- Test pre-commit hooks locally due to the major version bump
- Review the AWS CDK changelog for any breaking changes
- Run the updated Ruff linter locally to catch any new violations
The changes look reasonable, but please ensure proper testing is performed due to the pre-commit-hooks major version update.
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v5.0.0 | ||
| rev: v6.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to pre-commit-hooks v6.0.0 is a major version bump. While this update brings improvements, it's important to verify that all hooks continue to work as expected, especially custom hooks that might depend on specific pre-commit behavior.
| { | ||
| "dependencies": { | ||
| "aws-cdk": "2.1023.0" | ||
| "aws-cdk": "2.1027.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AWS CDK update from 2.1023.0 to 2.1027.0 is a minor version bump that includes potential bug fixes and improvements. Consider reviewing the CDK changelog for any breaking changes that might affect your infrastructure code.
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| # Ruff version. | ||
| rev: v0.12.7 | ||
| rev: v0.12.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ruff linter update to v0.12.11 includes new lint rules and fixes. Consider running the linter locally to catch any new violations before merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 237 237
=========================================
Hits 237 237 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.