-
Notifications
You must be signed in to change notification settings - Fork 39
WIP: geometry lookup #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
asinghvi17
wants to merge
58
commits into
main
Choose a base branch
from
as/vectordatacubes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: geometry lookup #854
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
5dcb1f7
WIP: geometry lookup
asinghvi17 4bccf40
Multi/polygon writing
asinghvi17 6717902
Add crs, reproject
asinghvi17 8d6f670
Hook up CRS, export GeometryLookup
asinghvi17 b614376
add super basic tests
asinghvi17 5ec0af6
Merge branch 'main' into as/vectordatacubes
asinghvi17 ab7d427
move geometry_lookup to a folder
asinghvi17 1c55155
add overrides for zonal when it's passed a GeometryLookup or dim that…
asinghvi17 55cb66d
make zonal use the fast-path missing return only if skipmissing = true
asinghvi17 5f6b368
implement automatic spatial slicing for datacubes
asinghvi17 09d8ac3
add comments, set `spatialslices` to `_True` initially for assured const
asinghvi17 3757a35
fix geomlookup method
asinghvi17 aa1bcc5
wip fancy rebuild / dim detection
asinghvi17 debb290
implement isfalse
asinghvi17 16ef85b
add a missingval kwarg so we can fix things correctly
asinghvi17 af2e447
missingval support
asinghvi17 233018f
fix run: remove static, let threaded be anything for extensibility
asinghvi17 41ef26e
pass spatial slices through the geometrylookup zonal
asinghvi17 1b7d26c
disallow missings in geom lookup
asinghvi17 19775da
allow metadata kwarg to rebuild
asinghvi17 97474fe
plotting support for dim 1 vectordatacubes
asinghvi17 e1ab26d
default missingval is missing not nothing
asinghvi17 b0293ca
Geometry named dim
asinghvi17 dba05f3
harvest crs from collections
asinghvi17 1ba940b
move io to new file
asinghvi17 0237228
dispatch on Dimension not Dim
asinghvi17 b69192e
plot for skip missing
asinghvi17 0d31b48
fix crs
asinghvi17 9db69a1
use traittarget in io
asinghvi17 f123e70
move lookup methods to lookups.jl
asinghvi17 645e9dc
don't slice if the dims are already only x and y
asinghvi17 cee0dae
add tests but GeometryOps is broken for this one
asinghvi17 e600bed
better label in plot
asinghvi17 aed90c8
move reproject to methods
asinghvi17 5ecde8f
handle empty data, do not create trees for it
asinghvi17 07ba496
make geometry lookup an abstract merged
asinghvi17 4624c5a
enable lookups for per-dim touches and intervals
asinghvi17 f13d0db
add sources
asinghvi17 d0c68f1
rebuild stacks in regular zonal
asinghvi17 cd71100
updates for DD pr
asinghvi17 3bd7451
fix
asinghvi17 f89e23b
make crs better on rasters
asinghvi17 2e44421
allow Near on points
asinghvi17 2184b92
enable at on points / forward for other things
asinghvi17 88230bb
fix touches
asinghvi17 626b8ee
minor fixes
asinghvi17 899b36a
make extract multidimensional
asinghvi17 26ce1a0
make the change non breaking
asinghvi17 a97ae9f
Clean up lookups
asinghvi17 056cd0d
Update methods.jl
asinghvi17 3b052b9
Update zonal.jl
asinghvi17 629cf6a
only run zonal if not on fast, all-is-missing path
asinghvi17 4a56b50
basic netcdf io, could be more optimized / streamlike
asinghvi17 3c1cc29
fix
asinghvi17 71700f5
add some test files as text that can be fed into ncgen
asinghvi17 eb6fa75
add decoders for all geomtraits
asinghvi17 e9f5186
use the test files in nc_io.jl which should now be a test file
asinghvi17 e94b28b
fully implement, and "test" all six geom types
asinghvi17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaqz would like to get your opinion on this, not sure how breaking this will be to end users, who may now get an empty array where previously the function they provided wasn't even called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from Slack this is extremely cool and we should do this