arm64: dts: rockchip: radxa-e24c: read MAC addresses from EEPROM #505
+112
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj123lsjlsj
requested review from
RadxaMitchell,
RadxaStephen and
RadxaYuntian
Signed-off-by: SongJun Li <lisongjun@radxa.com>
Signed-off-by: SongJun Li <lisongjun@radxa.com>
lsj123lsjlsj
force-pushed
the
e24c-eeprom-mac
branch
from
b4b7a44 to
b428a76
Compare
Member
RadxaYuntian
left a comment
RadxaYuntian
left a comment
There was a problem hiding this comment.
我感觉怎么又在弄一个新实现，之前不是说有一个基于starfive的eeprom格式么？那个不是已经写过了一个配置mac的实现了
Signed-off-by: SongJun Li <lisongjun@radxa.com>
Member
RadxaYuntian
left a comment
RadxaYuntian
left a comment
There was a problem hiding this comment.
所以这个local-mac-address/mac-at-eeprom是我们自己加的一个值咯？这个应该很难让第三方系统支持
phy的mac应该可以从uboot配置吧？
| } | ||
|
|
||
| /* 24c16 uses 1-byte address */ | ||
| if (offset > 0xff) { |
Author
There was a problem hiding this comment.
那这里多加一个if (offset + len - 1 > 0xff)么
Member
There was a problem hiding this comment.
我的意思是最好是看看下面uboot那个实现，用上游支持比较好的接口
| goto out_put_np; | ||
| } | ||
|
|
||
| if (len != ETH_ALEN) { |
Author
There was a problem hiding this comment.
这里是比如 dts 配置成 local-mac-address = [00 48 54 20 00 ]; 或者 local-mac-address = [00 48 54 20 00 02 03]; 那驱动会检测这个长度
Author
这个是针对交换机芯片的 PORT, u-boot 传递的 mac 地址没法传递给 SWITCH PORT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net: dsa: add support for reading port MAC addresses from EEPROM