*: support backup/restore with NFS #148 #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acekingke
requested review from
andyli029,
dingyuan408,
hustjieke and
qianfen2021
acekingke
force-pushed
the
backupForNFS
branch
from
93b600b to
b4464d4
Compare
runkecheng
reviewed
Sep 24, 2021
acekingke
force-pushed
the
backupForNFS
branch
2 times, most recently
from
24fe030 to
3993290
Compare
runkecheng
requested changes
Oct 13, 2021
acekingke
force-pushed
the
backupForNFS
branch
2 times, most recently
from
6621a02 to
39f5f36
Compare
acekingke
force-pushed
the
backupForNFS
branch
from
39f5f36 to
8c61da3
Compare
Contributor
|
staticcheck Failed. |
andyli029
reviewed
Apr 14, 2022
andyli029
reviewed
Apr 14, 2022
andyli029
reviewed
Apr 14, 2022
backup/syncer/job.go
Outdated
| in.RestartPolicy = corev1.RestartPolicyNever | ||
| sctName := fmt.Sprintf("%s-secret", s.backup.Spec.ClusterName) | ||
| in.Containers[0].Name = utils.ContainerBackupName | ||
|
|
andyli029
reviewed
Apr 14, 2022
andyli029
reviewed
Apr 14, 2022
andyli029
requested review from
andyli029
and removed request for
dingyuan408 and
hustjieke
runkecheng
requested changes
Apr 15, 2022
acekingke
force-pushed
the
backupForNFS
branch
2 times, most recently
from
33b55de to
be0f265
Compare
andyli029
reviewed
Apr 15, 2022
runkecheng
requested changes
Apr 15, 2022
Collaborator
There was a problem hiding this comment.
The name of the backup folder cannot distinguish the backup of multiple clusters, Change the name such as <cluster_name>_202241564422.
sh-4.2# ls exports/
backup_202241564422 index.html
sh-4.2# ls exports/backup_202241564422/
backup-my.cnf ibdata1 performance_schema sys xtrabackup_checkpoints xtrabackup_logfile
ib_buffer_pool mysql radondb xtrabackup_binlog_info xtrabackup_info
Contributor
Author
|
#232 (comment) |
runkecheng
reviewed
Apr 15, 2022
acekingke
force-pushed
the
backupForNFS
branch
3 times, most recently
from
9851f02 to
21a5c93
Compare
runkecheng
reviewed
Apr 15, 2022
Contributor
Author
it has been modified |
runkecheng
reviewed
Apr 18, 2022
| name: backup-sample | ||
| spec: | ||
| # Add fields here | ||
| image: radondb/mysql-sidecar:latest |
Collaborator
There was a problem hiding this comment.
mysql57-sidecar:v2.2.0
runkecheng
approved these changes
Apr 18, 2022
andyli029
approved these changes
Apr 18, 2022
Contributor
andyli029
left a comment
andyli029
left a comment
There was a problem hiding this comment.
Merge first, optimize further.
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
*: support backup/restore with NFS radondb#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #148
What this PR does?
Summary:
Special notes for your reviewer?